Message ID | 20230401161938.2503204-29-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0Tpn6xmG; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=YRAPq4/x; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppkl001rpz1yYP for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 03:33:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0bzUaQiEwSc8NXx0Q8VSuyuzYvCX8BTcWWsfqGEujGs=; b=0Tpn6xmGndgjAy dKTP3oP9/LSIcS3ZU4RoqDTJv6zc/ele9Dugww2a4q5NHVeU6wlw/APINfeb5wRi+VD4nfR+GRrMQ Hmq68htM0VJAUM+uYqSU5NkPJ/ECaqEjBNx/rmfHem2CKxd6AeMPN24maAY7RbIbPsSfLDkz3j3iA bnYgi16lFRWREoWCtkjxcOQb/3Ev7d7dK5bMdgcfNZMLfjmBuGExyHy9ZaBCmYh99z4AGRWgTsFXm jzsAPNde5wB88+O1DT1lJVZ7y7BsiKvbnquzOBoxEpcfdw4EDqions2I4YO1EeGpKNsklsq8yt/C7 TmnO+233krQ/DIW/ltNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pif4k-00B2Pr-21; Sat, 01 Apr 2023 17:31:38 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxc-00AsHA-2f for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=9g2XiRb2pnd7KmX0ldCm1r7c3ccrsCXtiEohe3dK6Ys=; b=YRAPq4/xQWzYu9S4W1GKMt17mJ mdMXX9V9gjyope9rYVlPnPTqKyR2RJJy0klRW4qhSIB9OWz1j+VEiq+M6JjSf7obCW1OO12jIwOym MTrk0Oa6DTTaUNOAd/x6zykCCMkG/AfOiClnpEbexx5ULfygKeQvPUuxw9h2rqKLxBRH8pqqR2FBD vcJ8BqxILJUei6Zqd4DMLccqgPc9YPgRTZ59g06bTVfyggpUF4E2PnQqRMkOcMSA9tLtUu5Fe66iB 7qFMdN97nG6pkJTfP4PqXyK9PI7gWZIEEEE6eoewZ5kkLhKN7foCM7MumAUSUguUw4XfVECLnAo0E DFLG1AEw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKr-1e for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxK-0008NT-6E; Sat, 01 Apr 2023 18:19:54 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxI-008GRk-SJ; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxI-009kgr-5q; Sat, 01 Apr 2023 18:19:52 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 28/49] mtd: rawnand: mxc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:17 +0200 Message-Id: <20230401161938.2503204-29-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1739; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=e4xzjXYDfJ+j8bymws7/MFBHTs5gYDu3T17rMOhPFqo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkuo7wKq/dC8HZ2p2Nnddl0rATHBKXP80foQ IxkORnbMzOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZLgAKCRCPgPtYfRL+ TvzgB/9yQjk4eMNBRoW9TxCvZOT09JOOHUCBaduZhz09ey/Lp+U068wjqWj1DqbIvk+QXniEJr6 V16jBFRutztO5vbYwAjCQMVF91uvGc7Ebp0sYqb8n++vAaQo6MBfLzNwpwzv175FJTI7d/O4+2f KCFEy8TaCv6U2FU2DqIeJvZMQmwGJoIuxAixXLMr7mvWDfHUIF4JxrxgL2UfjfMycjWaAEGJpQN 8gI4bwVs0mKYice+YrPzZ2gVLoyu7DATKqIWnUND20NnC9JZUMXI5cdj0djdsO+x8Kn0F+SqQnD OtNUlP8bw4To7G62sXyPF4t7vaTmEE3NudujJQ3H1C8XBLTL X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_933086_109288D5 X-CRM114-Status: GOOD ( 15.82 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c index f6c96341b896..56c1046cc073 100644 --- a/drivers/mtd/nand/raw/mxc_nand.c +++ b/drivers/mtd/nand/raw/mxc_nand.c @@ -1831,7 +1831,7 @@ static int mxcnd_probe(struct platform_device *pdev) return err; } -static int mxcnd_remove(struct platform_device *pdev) +static void mxcnd_remove(struct platform_device *pdev) { struct mxc_nand_host *host = platform_get_drvdata(pdev); struct nand_chip *chip = &host->nand; @@ -1842,8 +1842,6 @@ static int mxcnd_remove(struct platform_device *pdev) nand_cleanup(chip); if (host->clk_act) clk_disable_unprepare(host->clk); - - return 0; } static struct platform_driver mxcnd_driver = { @@ -1852,7 +1850,7 @@ static struct platform_driver mxcnd_driver = { .of_match_table = mxcnd_dt_ids, }, .probe = mxcnd_probe, - .remove = mxcnd_remove, + .remove_new = mxcnd_remove, }; module_platform_driver(mxcnd_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/mxc_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)