Message ID | 20230401161938.2503204-14-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Xz5TySzt; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=dUGEA9Zn; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjX36B21z1yY8 for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 02:38:27 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4oJbiIkRfSuTNUMaBj5n/wFGI3/gr2cPVB0XMnSWkhI=; b=Xz5TySztgBWFHW KDeV8vAN+4oxV3DVs4ePYKuqZTNAq4FkYqhk8Q22I7lzQTjHgTfEbZxeLPR3f9PH9UlcV1jC8/5YS pX/YxZAxGA4ni5kfuCN2yrumJgtILUD/aZD/RFSw1xpxE2jGAGfT8CtjRjalr2dt32gCQazm6Mf2q 3a3Hiq5gVeJTHG0cCR5xfE0xoOwAqSDHuzABEcG2grm/hab6EqXeSCr7hJmHS9QSPjLIqf5GCFi2e D0VlQYL4d5eGc1CAQmS3SyQRRss4gXvJHxeUJKJWLY6kjnbgSfo5EFJC23W73xLGbXfEVCjAUc+yc DOSn32VL6BiDIbSoGnNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEi-00AwnO-1N; Sat, 01 Apr 2023 16:37:52 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEM-00AwRk-1m for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=1XNmrMy+Da78LTZx0o0AjKxWoVKumJIsPm1ctORoeok=; b=dUGEA9Znbf6gfn2pUBBy97ESEI +/ms2TDJI1pgMmYB4zzptGLAv5ptBaTw6mvWBA0bg5J0aGWoBPIRVEYr15nkVr5BbSN/WX8G8cUS7 WhM9PUv/xn039XMJzjQXQfx2g9o/b33YIju32fSxUJ5d90De967RaX+srqirHijrJhzvP4oN5E+1L bzYwbwM3pRJYVSfQulrzhaf8XSj6PTlfrW8K1oitpedC2QYUJ7FX7ExzJdXpnuc4+wWu8m1ESa1Vz Z5wVOovqKHb+6DP9Lm02H2wCyb7m+w7d/V/hB7DWrwRQDs3jqdkeK/YAgtDQN4KKfu1+EL9VhU2oO smuk7aQg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOD-K1 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:09 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxH-0008Cb-4K; Sat, 01 Apr 2023 18:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxG-008GQb-5K; Sat, 01 Apr 2023 18:19:50 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxE-009kft-Vw; Sat, 01 Apr 2023 18:19:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, =?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>, =?utf-8?q?Marek_Beh=C3=BAn?= <kabel@kernel.org> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 13/49] mtd: rawnand: fsl_elbc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:02 +0200 Message-Id: <20230401161938.2503204-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1839; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=yfVH0jbDdqw7wRLZMJmiFxpHx5shhXL+m8ng86xuQIs=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNiH9K0XOOsa+azBi2uHjeTxf3mVZtlTu2zJTb5vPrX 31oX/P0TkZjFgZGLgZZMUUW+8Y1mVZVcpGda/9dhhnEygQyhYGLUwAmMieZg2Fd+OTHWq9znx9n Dg4JaVgkK+Nx629So8uBbWvCZ5yNDTN6Fl3iwHF6erXuVKFJ3zK3sEQlLF3Mt7+6slDDQeKPvSe bPrO+bPDjSJsqJpGOhttr1i7aV7M59W6rUcJvD7Mt3u4nbDp/qyQwlrBJ/uftnW1ndGi+dVbA3E Msx6tfH2Due648U7nFy9G0xTeQlXGNwe3UT241tkdUeT4ZObyO4jQ/ZcVx0fEZTxqDc+sH5nyNi s9HlMq5V57TltIs2DfL2ezd6uAoGbeECS/tC7KVnb0uzObZe+H+x1vPDnyc91NOdc88TbbsOsuj v61P3+ELy3Y4o6z+71N5Rtgq0ZsT3IQ2FHJf4ZROPG4IAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_823268_07E93654 X-CRM114-Status: GOOD ( 13.13 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/fsl_elbc_nand.c b/drivers/mtd/nand/raw/fsl_elbc_nand.c index e25119e58b69..1e3a80f06f33 100644 --- a/drivers/mtd/nand/raw/fsl_elbc_nand.c +++ b/drivers/mtd/nand/raw/fsl_elbc_nand.c @@ -963,7 +963,7 @@ static int fsl_elbc_nand_probe(struct platform_device *pdev) return ret; } -static int fsl_elbc_nand_remove(struct platform_device *pdev) +static void fsl_elbc_nand_remove(struct platform_device *pdev) { struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl = fsl_lbc_ctrl_dev->nand; struct fsl_elbc_mtd *priv = dev_get_drvdata(&pdev->dev); @@ -984,8 +984,6 @@ static int fsl_elbc_nand_remove(struct platform_device *pdev) } mutex_unlock(&fsl_elbc_nand_mutex); - return 0; - } static const struct of_device_id fsl_elbc_nand_match[] = { @@ -1000,7 +998,7 @@ static struct platform_driver fsl_elbc_nand_driver = { .of_match_table = fsl_elbc_nand_match, }, .probe = fsl_elbc_nand_probe, - .remove = fsl_elbc_nand_remove, + .remove_new = fsl_elbc_nand_remove, }; module_platform_driver(fsl_elbc_nand_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/fsl_elbc_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)