From patchwork Thu Mar 23 14:03:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bang Li X-Patchwork-Id: 1760336 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=eunNQHPo; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=J7irfwBK; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Pj6YG4Wljz1yXq for ; Fri, 24 Mar 2023 01:05:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3lDCpseVd+NNjhITG/UZ5APHwdbVQLjU2Sfy6G5ykLI=; b=eunNQHPoozs0Ue HbTK47L2c/ZsGkPQ1/eEWRW0ut4iGkZNN+ym4x2mlJLangQzsRXaNhDwFMUNVGywtYfCh8YZ26J9H 2EvNF9ZLWSD1nV/6sbkTd9XGE5Wu/6VD58ulBZQTQ0v6cSZkS96JJYbEI7OTzmy5wuSia7cjBloOq J09V5ehlXmbcgOfp90XXSyDzudMoAZkcY+WYlq4M8QE2qR97TJ5DfWtZSSwHBTT76ti72Tzquvqq8 8w/10NEdSPf5n1JOMkwpRbOaLNhrZmjdwx/jVSq2xMfO4AgqqfjbY83XSJ8v/zrxhZUTOnn+d68Ih EkIrMygUEGgSzXtRQFPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfLY2-00275c-0p; Thu, 23 Mar 2023 14:04:10 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfLXv-00274V-1i for linux-mtd@lists.infradead.org; Thu, 23 Mar 2023 14:04:08 +0000 Received: by mail-pl1-x630.google.com with SMTP id le6so22366544plb.12 for ; Thu, 23 Mar 2023 07:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679580241; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=m/FSVIgFkJKT5jPFJCXaDrLahDNeQHDN2HW+X//0cEg=; b=J7irfwBK/AlyWjxu7eOdGZc3k24K4lB+89Vl/zz4hK5xhMiv41olFotAiTc+3WCGgy 4cMirpt3fatv777O2iGcdLsHqFxgzg0Of+Dx+r9KaQi3ZcX3E9Lncwgmy7noLBDjikH4 qeFPxJMXmBJ7rl7xsVcBu3NrRU89/WTJx5Y/FmB5rkNHCTn354ln3Hu1p+V0UCD4z7q+ lZ7EoPbT6M4jOPrAj1w3LZOiSIxcjONMuB+R15oUGS+9n2BS5pt2GsGMTGnVqeshSECB PvejD3n6QPnwaE1fyXtLr7FvpOotEGMK3LXpiL4twfF5nd37v0qBb4ILaEy1GnA4JSbY Bjgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679580241; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m/FSVIgFkJKT5jPFJCXaDrLahDNeQHDN2HW+X//0cEg=; b=upCqE3dzW5aqsEO4Gv3zIqq+3MJ05xPz7UsQcY4yLvMREzpmmEjqbFL/KJIdWg/swp 3j06l931toAnL8WSHXi4r87Dvu1HYp99YGutsdw3SBsvpzGp7wzJpJt06vHZYjs8TrcA i3yzUm1TZudU8x34BChgoqYLP7Fu5qF3kBKY7mqJPVudSH4kDL2D4qYoZ12lAv4BYu39 QNhMZgFbd9I1mnRhCo2Wc3EQX4qDMOJF/D7lH73gtsr9DcTmeXg0NcXMQxE+U4UKSwI9 EAS9EVgcD8aIvLgXLovhCFHa/2hjAY0tOQtsWOjm+xiq80s8BWtAOtC7X6z9z1EV75Jm YW8w== X-Gm-Message-State: AO0yUKUX0myQzqyJx+6GwX7lT5/SnHdDwAdEGm3SYP5qE2axgy4in0pp irY9Ho/OWV6w+R/6jm7LPuisOVhtL/fOi2+Y X-Google-Smtp-Source: AK7set+No4CboYrqtpIMXSn3p5AoVWa7v7kwsrrDO8wk4wxo/FiN6fQ5stgd6ORe1owxLtO0hvB1mA== X-Received: by 2002:a17:902:ebcf:b0:1a1:dc27:202b with SMTP id p15-20020a170902ebcf00b001a1dc27202bmr6165242plg.20.1679580241020; Thu, 23 Mar 2023 07:04:01 -0700 (PDT) Received: from localhost.localdomain ([115.204.224.149]) by smtp.gmail.com with ESMTPSA id x12-20020a1709029a4c00b001a1a9a639c2sm11967376plv.134.2023.03.23.07.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 07:04:00 -0700 (PDT) From: Bang Li To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Bang Li Subject: [PATCH] mtdblock: tolerate corrected bit-flips Date: Thu, 23 Mar 2023 22:03:50 +0800 Message-Id: <20230323140350.69908-1-libang.linuxer@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_070403_586787_F4466386 X-CRM114-Status: GOOD ( 11.83 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: mtd_read() may return -EUCLEAN in case of corrected bit-flips.This particular condition should not be treated like an error. Signed-off-by: Bang Li --- drivers/mtd/mtdblock.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:630 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [libang.linuxer[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org mtd_read() may return -EUCLEAN in case of corrected bit-flips.This particular condition should not be treated like an error. Signed-off-by: Bang Li --- drivers/mtd/mtdblock.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c index 1e94e7d10b8b..a0a1194dc1d9 100644 --- a/drivers/mtd/mtdblock.c +++ b/drivers/mtd/mtdblock.c @@ -153,7 +153,7 @@ static int do_cached_write (struct mtdblk_dev *mtdblk, unsigned long pos, mtdblk->cache_state = STATE_EMPTY; ret = mtd_read(mtd, sect_start, sect_size, &retlen, mtdblk->cache_data); - if (ret) + if (ret && !mtd_is_bitflip(ret)) return ret; if (retlen != sect_size) return -EIO; @@ -188,8 +188,12 @@ static int do_cached_read (struct mtdblk_dev *mtdblk, unsigned long pos, pr_debug("mtdblock: read on \"%s\" at 0x%lx, size 0x%x\n", mtd->name, pos, len); - if (!sect_size) - return mtd_read(mtd, pos, len, &retlen, buf); + if (!sect_size) { + ret = mtd_read(mtd, pos, len, &retlen, buf); + if (ret && !mtd_is_bitflip(ret)) + return ret; + return 0; + } while (len > 0) { unsigned long sect_start = (pos/sect_size)*sect_size; @@ -209,7 +213,7 @@ static int do_cached_read (struct mtdblk_dev *mtdblk, unsigned long pos, memcpy (buf, mtdblk->cache_data + offset, size); } else { ret = mtd_read(mtd, pos, size, &retlen, buf); - if (ret) + if (ret && !mtd_is_bitflip(ret)) return ret; if (retlen != size) return -EIO;