From patchwork Fri Oct 7 10:48:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Kshevetskiy X-Patchwork-Id: 1687340 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=okfr0IFo; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.a=rsa-sha256 header.s=selector1 header.b=V6XV1qGN; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MkQ6g3mMxz1yqk for ; Fri, 7 Oct 2022 21:49:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=phrsb7iw7rvN9mqpsdHg9/65TniV7hiY7T7E1W0phOU=; b=okfr0IFoDoZtOU ylqE02LHVn97GA+73E7WS1dykpZTON4GryVW0z4X1lNn9Sj4LjoRuhWl6WeKy/cyVG4n2P0pxNeaS uaBCYYzGVUwf73kZqqPyREPme1MUK9kWdSl3LO1fnnP3WCQAkivExM2Tx1dIBxuPByV9TNawj3XGa C1TxfFClyH75K5G+YdegoV3tliH/zRhzuPSAWO5RlIekogpAKR1tbooaiibwkIp5g6KapFmWsv4fi gp+vTMXhpkatW3zM2NZYgg+PtbnCRpAEztrKJDh+Gt3C3i9SoEnqMq+0R0vt275gHkfFRgmeWGB3Q 9m771581jUr5J92bpHgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogkuA-008bpl-HU; Fri, 07 Oct 2022 10:48:34 +0000 Received: from mail-am6eur05on2055.outbound.protection.outlook.com ([40.107.22.55] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogku7-008boe-IY for linux-mtd@lists.infradead.org; Fri, 07 Oct 2022 10:48:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SVkpD6at8SDdaMY72hUyUMbKMI0YL2dmGc9gbq/B+cEAoDtYH8rZRAawwxJxLaJe1UE/NhMSEzlDEym3UjZqCOixcQX4U2kZSEuBQ4qLrvfvugEa+dazx690eFoqXVQBOtl1Fqb0zs1AA5GvTPiwvQWPgONw4CMYki9YgpY8hq+ZKTMWqrhg6dXChyiiYHQBp/5PtrSrk+Spn3Np7cTPr6BOQhLE1CauLOrWJyn0FKP/vxzhgZP0izBBWLJEl8eaSrQrYThRdI/saGgfAr81f2/LeC3CyomilFbOp4jB1NXoSH+gVe3JN1ju9vGT+6W1qYff/zPqSeHA9BO0GmfS0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HW9D+BSmI6pRhbYTKCGKsKv+BuzjNz4WwrRy7sRVd8I=; b=n4MzYqJ2trZ/IMe4A0N626FdichAwrFThsmWmAR5DP6ztNZDn17pLKKUFBeQAWV+ji+rEWLE5GGDRk1p+7gm+XWeT/ZEz8Rpg2ElOdVSc4DwtBczgL04WiAbOexxTCRMKRdN6DJ0uoX7Qp1eU96G4TH30WHtE1Gqt2fm63pfC2M0HmXYh5W3emyOixSVdy6jVcw2KrnCqkfY2nY4IpYGlnanHfaqUnGNPmRT/9AF2Ztb7PXK8SrDbZZTZFL9rXeOHilKAqQ7LnP7vzdeEO42ClbnVYc/1XxgFb8PSgw35duhKm0+6x8qfFpNAAiPR1pwcsQuSR4XdydWeRmPeXM9gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=iopsys.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HW9D+BSmI6pRhbYTKCGKsKv+BuzjNz4WwrRy7sRVd8I=; b=V6XV1qGNoKk04Sjv4wlqFHhNJ1ZKmnk7LkmCVFPtaGif/PzJ7b/0Fux34XPHmtyEC0tfSbWcomXG1QogiMeay2q0tFYcNHuaRK7LoPP+zOlf9znJSW7SOZHE2ns7INGQG6i9Dw90kv5mwSsME1VnVDLy5PAbQtt7t+KgUBgaXMA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from PAXPR08MB6494.eurprd08.prod.outlook.com (2603:10a6:102:154::16) by DB9PR08MB8457.eurprd08.prod.outlook.com (2603:10a6:10:3d7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Fri, 7 Oct 2022 10:48:28 +0000 Received: from PAXPR08MB6494.eurprd08.prod.outlook.com ([fe80::3c25:b934:e13d:d6bd]) by PAXPR08MB6494.eurprd08.prod.outlook.com ([fe80::3c25:b934:e13d:d6bd%5]) with mapi id 15.20.5676.032; Fri, 7 Oct 2022 10:48:28 +0000 From: mikhail.kshevetskiy@iopsys.eu To: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: Mikhail Kshevetskiy , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Frieder Schrempf Subject: [PATCH 1/2] mtd: spinand: winbond: fix winbond lashes identifications Date: Fri, 7 Oct 2022 13:48:19 +0300 Message-Id: <20221007104820.198938-1-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.35.1 X-ClientProxiedBy: GV3P280CA0013.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:b::34) To PAXPR08MB6494.eurprd08.prod.outlook.com (2603:10a6:102:154::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6494:EE_|DB9PR08MB8457:EE_ X-MS-Office365-Filtering-Correlation-Id: ba979715-4610-4e1c-c88c-08daa85177db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3y+WKAip/xh5zr+B+f8S3Hyj9hQlp3YGksfCP8Q3WUMFaV1z/h3Yyrlt9RjFTG+YP6fSE3AdjGeoQKPc3InJ4JwxnvYjqyeulGaJft96cyb/G/noBQBCBnBTsqn6hCwNGFBtatXI1UXAu5b2VGgvTHh51gqqDCLYQFB8q4+asekihevLDbWnkJa8pQRrXDbk6Ta2KeGCM42XE3gH+bXBqiRxEhSEoy6W9IiQ9pZV71nDQ9jjc+nzHKfCwydj3tOroiaQ8yjfrus8nszOTIKFFtryZxlazKpntYF5kwS+WBiUCRpl4Nj/dCYoKnqS6s9oKe6Q20m3ykpIdPiLBg2Vs0fEWr10ipvVgfBrDFakmxiOskzgYGrouAQbuooR1oEVeappTW0/bzetPaJLj0j1LrOlxiouUJGdXvTAoEXze3Ba7trDH1753zf8urjmQyqb1DBt6VqnBS72Xnwunqwh0+7SwvEKFZZyXVmGDezYkAhWqoA7UgPZgrR2pmv1yzwGJ6yIq8df5aUB+9KuKCMyIoqzPXCCo+oOGRWLoYInId7DiHUIQbNSg40gW2884tNu9C9vDif5RbykWq8o1kYkfppXRuN9H7eEkzIAO8uSBENPItUNwi74mEXXUD1L7uJr338oslafz/qC6JhZ4xewbcr5YZ+n9453a5YfdmNlOQtF92yA9Hm8tpEwvn7WMRL+kh01sI2MaLwOXxolTtO+DyYwx0yC+k1zWuZb1M9Hir/M3R5NlEzQ3844wauJzMjGKAkdM5KvfGoOd4ijXE9TRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6494.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39840400004)(346002)(376002)(366004)(396003)(451199015)(8676002)(38350700002)(66946007)(36756003)(66556008)(66476007)(186003)(38100700002)(1076003)(41300700001)(6666004)(2616005)(86362001)(4326008)(52116002)(83380400001)(2906002)(5660300002)(6506007)(26005)(8936002)(6512007)(9686003)(6486002)(316002)(54906003)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hUNcGgEZyju1Wwc2GLY5gJ3uYoaLY8in+Hme2HmfB9cZAmnNPs8KqLgOAXmdP8B6p3JSk9UjHrCdgj9x7YL3ajIVj+EIw4AqMFDjk/KWWBdyyxtgqVoxNh8/of8eBN0nm611O7PDyA0VCUx6rtBOWyZ7inRcWN4p+0toyhNz+bo0DtDKxLaT5t7sLOmazcCtIWJPAa7PDJHmSpL+6e+BGN2St6XosQUL9UevKdvPlOWczbO6ii7J7d21Xp5jBRTOPXBuzPv+qAVVk9UBrDek1m2/3DP6Jm7aXgC04dx+7G1q9uAsrp3TBDEvumsVjXB5JwRz8xPSedz0UKNeJ6icOnqPPXiO1IetlNHkq6rzPoJIY8EEhrybIY9XIZOmI7VXLmDIRJrIz+H0fl4NVtOQ42FR7rcXbpMCiyES06fkgELpt4tHA0V4+pIEyyeO66SZUdT0+aP0S7jxyVzRDvwK5kdZIxayIf/prJBEQIz+wpsFSnsc7vqCA0ZW2pATNWFaHGVoqsAqG04xQKcC3TLMnClvgdupKz3/+somqoHHM/Q2VL9XB+nOw57gQMpAc5veK6/YnTGvahcgSTTlIGja+63UQ+2sGsIimuftK5N1waejX+hBIfL3vrKXJTCg5fWO8+nx/FnDgc2b3hIIfkoV7MtPwQtbM9db8RYKCFJfGRlBddM9D8y4PX4I19Cnmxw/R8dZTAbgLfuqQnPfeNHvZkWFc3PL/lMNTnKox4PE6dRznrTioZ7511BsxMQwbH++hUWm715P5KjqKAjxc7Q/+N1asKMVz/wYyH3nPfl0oVcAiaxt7My4q81RP0V82v+oBhJjpPaKv+hfTU8DwNQlmXWdXYsMLXb3pd07AX3aCAqzsMG2vSMt2Jif0Lh76639YxfdRCmULjAdP6HyRgae/dXjgpvSTC0KeQaZcZcFNN4pZepKOmQIv26H/LLs+VnCzGH4jRqRb82jf+Z9b/QHp/E5CCONRQBapPBgrs4y9WAQrnvUXUAYUqaoYgA1t5n4Iz3mUi3WUS57daviqID2Xibi4GryXyXWvoIHCLVv4dJEjGxOhGSOYTO884I7ia+FEBCZqu3jZlzHhOP3GjDkZbJRiMujGjHYmvIdDVwTOFRctz7r1TF4DsSG/MB0SfJl3ef33wwaFbyb6o+2ZWFzrtftNR/6bAtMQgIIFOrnUAyR0F1NC7AuQ8xkLGKn753KgOxe8xAUeug1qvaxTjON+08tFfn5voqWkfWawhooYXrSqxYnEo5U5nOur7FK5Eb29hRibujO5PIuUXczoRLIUUrM+EGM1xdw2AR/y2hEJuMMngLSGP17UXeCa82kbQ6nNtHn8Gr+HtmT4RfiifEc2CoBz0H/HtqehuG1YnL89XExlNOO2x+BI/mApDKT2sADLSKjvnyVk5H86B7kfEjLaoBDPeo1a6cFKB4VYQSuZjWN7aWvh/58SOZtsSGvBXPCeJjPJE8loAlwHartRenLUbjRWNTU4sa+JONqd1BuPOzex2VmGCol/Rz98tXVyrxnOTLu+D+97Rnov3e50ekbO/CHoDJh5s8bFKYZ0WKkyD7d73ohFgJV2M+sttBJHSHOCC8guSXVXlRs7XwBKV1vqDVv69rQdOf5PKhKAIyjiUM= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: ba979715-4610-4e1c-c88c-08daa85177db X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 10:48:28.4631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ff78d65-2de4-40f5-8675-0569e5c7a65d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dKJlIlVwTut+Pb86U8WegfTSV52OGBGfvpSItwf4mAOoBB5ZObJJbph2iaqjsZf6QM7Azt6cDilvEy2RLmzRUHa76Cc03vKRJgrvljcKF+E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8457 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221007_034831_622819_FA16ABF6 X-CRM114-Status: GOOD ( 10.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Mikhail Kshevetskiy Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1, but current driver uses only first 2 bytes of it for devices idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.22.55 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.22.55 listed in wl.mailspike.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Mikhail Kshevetskiy Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1, but current driver uses only first 2 bytes of it for devices idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22) is identified as W25N01GV (id_bytes: EF, AA, 21). Fix this by adding missed identification bytes. Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/winbond.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c index 76684428354e..ed368a55d68f 100644 --- a/drivers/mtd/nand/spi/winbond.c +++ b/drivers/mtd/nand/spi/winbond.c @@ -76,7 +76,7 @@ static int w25m02gv_select_target(struct spinand_device *spinand, static const struct spinand_info winbond_spinand_table[] = { SPINAND_INFO("W25M02GV", - SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xab), + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xab, 0x21), NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 2), NAND_ECCREQ(1, 512), SPINAND_INFO_OP_VARIANTS(&read_cache_variants, @@ -86,7 +86,7 @@ static const struct spinand_info winbond_spinand_table[] = { SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL), SPINAND_SELECT_TARGET(w25m02gv_select_target)), SPINAND_INFO("W25N01GV", - SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xaa), + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xaa, 0x21), NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1), NAND_ECCREQ(1, 512), SPINAND_INFO_OP_VARIANTS(&read_cache_variants,