diff mbox series

[mtd-utils] nandflipbits: fix corrupted oob

Message ID 20220616073943.669332-1-christophe.kerello@foss.st.com
State Superseded
Delegated to: David Oberhollenzer
Headers show
Series [mtd-utils] nandflipbits: fix corrupted oob | expand

Commit Message

Christophe Kerello June 16, 2022, 7:39 a.m. UTC 
If a bit is flipped in block 1 or higher, the OOB is corrupted with the
OOB of block 0. Mtd_read_oob API has to take into account the block number
to be able to calculate the right offset.

Fixes: 9fc8db29cf62 ("mtd-utils: Add nandflipbits tool")
Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
---
 nand-utils/nandflipbits.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

David Oberhollenzer June 27, 2022, 6:03 a.m. UTC | #1 
Applied to mtd-utils.git master

Thanks,

David
diff mbox series

Patch

diff --git a/nand-utils/nandflipbits.c b/nand-utils/nandflipbits.c
index aa6850f..cd66d0b 100644
--- a/nand-utils/nandflipbits.c
+++ b/nand-utils/nandflipbits.c
@@ -249,7 +249,9 @@  int main(int argc, char **argv)
 
 			bufoffs += mtd.min_io_size;
 
-			ret = mtd_read_oob(mtd_desc, &mtd, fd, blkoffs,
+			ret = mtd_read_oob(mtd_desc, &mtd, fd,
+					   bit_to_flip->block * mtd.eb_size +
+					   blkoffs,
 					   mtd.oob_size, buffer + bufoffs);
 			if (ret) {
 				fprintf(stderr, "MTD OOB read failure\n");