| Message ID | 20220607185918.1048204-1-chunkeey@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] Revert "mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash" | expand |
On Tue, 2022-06-07 at 18:59:18 UTC, Christian Lamparter wrote: > This reverts commit 3380557fc7e28d9bce7607e16d98f123d36da4ca. > > It turned out this "4-byte" ID might have been an honest mistake. > Regrettably, the chip Andreas has might be a counterfeit or is > damaged in some other way and shouldn't have ended up in a router. > > Andreas reported his chip is returning just four bytes: > "98 f1 80 15 00 00 00 00". > > However, according to Kioxia/Toshiba's datasheet, there should > have been at least another byte that would have contained the > correct OOB size that Andreas needed. > > Miquel and Andreas are both favoring reverting the patch over > further, possibly hacky modifications: > "[Reverting] is the safest option here. Apart from this device, we > do not know how many devices have these damaged/counterfeit chips. > If it is just a couple and only on Fritzboxes, as suggested in the > Github issue the patch could be carried through OpenWrt[...]" > > Thanks to several users on the openwrt forum and github issue, > who stayed along for the ride: > - Peter-vdL for reporting the issue and testing patches. > - neg2led and Hannu Nyman who did all the > datasheet digging and debugging. > > Cc: Andreas Boehler <dev@aboehler.at> > Suggested-by: Andreas Boehler <dev@aboehler.at> > Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com> > Link: https://github.com/openwrt/openwrt/issues/9962 > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel
diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c index 88c2440b47d8..dacc5529b3df 100644 --- a/drivers/mtd/nand/raw/nand_ids.c +++ b/drivers/mtd/nand/raw/nand_ids.c @@ -29,9 +29,6 @@ struct nand_flash_dev nand_flash_ids[] = { {"TC58NVG0S3E 1G 3.3V 8-bit", { .id = {0x98, 0xd1, 0x90, 0x15, 0x76, 0x14, 0x01, 0x00} }, SZ_2K, SZ_128, SZ_128K, 0, 8, 64, NAND_ECC_INFO(1, SZ_512), }, - {"TC58NVG0S3HTA00 1G 3.3V 8-bit", - { .id = {0x98, 0xf1, 0x80, 0x15} }, - SZ_2K, SZ_128, SZ_128K, 0, 4, 128, NAND_ECC_INFO(8, SZ_512), }, {"TC58NVG2S0F 4G 3.3V 8-bit", { .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08} }, SZ_4K, SZ_512, SZ_256K, 0, 8, 224, NAND_ECC_INFO(4, SZ_512) },
This reverts commit 3380557fc7e28d9bce7607e16d98f123d36da4ca. It turned out this "4-byte" ID might have been an honest mistake. Regrettably, the chip Andreas has might be a counterfeit or is damaged in some other way and shouldn't have ended up in a router. Andreas reported his chip is returning just four bytes: "98 f1 80 15 00 00 00 00". However, according to Kioxia/Toshiba's datasheet, there should have been at least another byte that would have contained the correct OOB size that Andreas needed. Miquel and Andreas are both favoring reverting the patch over further, possibly hacky modifications: "[Reverting] is the safest option here. Apart from this device, we do not know how many devices have these damaged/counterfeit chips. If it is just a couple and only on Fritzboxes, as suggested in the Github issue the patch could be carried through OpenWrt[...]" Thanks to several users on the openwrt forum and github issue, who stayed along for the ride: - Peter-vdL for reporting the issue and testing patches. - neg2led and Hannu Nyman who did all the datasheet digging and debugging. Cc: Andreas Boehler <dev@aboehler.at> Suggested-by: Andreas Boehler <dev@aboehler.at> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://github.com/openwrt/openwrt/issues/9962 Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- v1->v2 - replaced the o-umlaut in Andreas' last name with "oe" <https://en.wikipedia.org/wiki/%C3%96> "In other languages that do not have the letter as part of the regular alphabet or in limited character sets such as ASCII, o-umlaut is frequently replaced with the digraph oe" - added note about why the revert option was taken (If the shout-out at the end is a problem, please just drop it then. I don't want to cause any privacy related stomage aches). --- drivers/mtd/nand/raw/nand_ids.c | 3 --- 1 file changed, 3 deletions(-)