| Message ID | 20220606192952.34957-1-chunkeey@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Revert "mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash" | expand |
Hi Christian, chunkeey@gmail.com wrote on Mon, 6 Jun 2022 21:29:52 +0200: > This reverts commit 3380557fc7e28d9bce7607e16d98f123d36da4ca. > > It turned out this "4-byte" ID might have been an honest mistake. > Regrettably, the chip Andreas has might be a counterfeit or is > damaged in some other way and shouldn't have ended up in a router. > > Andreas reported his chip is returning just four bytes: > "98 f1 80 15 00 00 00 00". > > However, according to Kioxia/Toshiba's datasheet, there should > have been at least another byte that would have contained the > correct OOB size that Andreas needed. Maybe here we should mention the other alternative and explain why we went for an immediate revert instead (knowing that we wnat to buy time to eventually properly fix it and possibly inventory the broken chips. > Thanks to Peter-vdL for reporting this issue and Hannu Nyman > as well as neg2led who did the debugging. Maybe you can refer here to OpenWRT tools otherwise the names do not mean anything? > Cc: Andreas B<C3><B6>hler <dev@aboehler.at> Looks like there is an issue with Andreas' name, I can fix it inline if you don't know how to proceed, and if you give me the right character to put there. > BugLink: https://github.com/openwrt/openwrt/issues/9962 Link: is enough :) > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> > --- > drivers/mtd/nand/raw/nand_ids.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c > index 88c2440b47d8..dacc5529b3df 100644 > --- a/drivers/mtd/nand/raw/nand_ids.c > +++ b/drivers/mtd/nand/raw/nand_ids.c > @@ -29,9 +29,6 @@ struct nand_flash_dev nand_flash_ids[] = { > {"TC58NVG0S3E 1G 3.3V 8-bit", > { .id = {0x98, 0xd1, 0x90, 0x15, 0x76, 0x14, 0x01, 0x00} }, > SZ_2K, SZ_128, SZ_128K, 0, 8, 64, NAND_ECC_INFO(1, SZ_512), }, > - {"TC58NVG0S3HTA00 1G 3.3V 8-bit", > - { .id = {0x98, 0xf1, 0x80, 0x15} }, > - SZ_2K, SZ_128, SZ_128K, 0, 4, 128, NAND_ECC_INFO(8, SZ_512), }, > {"TC58NVG2S0F 4G 3.3V 8-bit", > { .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08} }, > SZ_4K, SZ_512, SZ_256K, 0, 8, 224, NAND_ECC_INFO(4, SZ_512) }, Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c index 88c2440b47d8..dacc5529b3df 100644 --- a/drivers/mtd/nand/raw/nand_ids.c +++ b/drivers/mtd/nand/raw/nand_ids.c @@ -29,9 +29,6 @@ struct nand_flash_dev nand_flash_ids[] = { {"TC58NVG0S3E 1G 3.3V 8-bit", { .id = {0x98, 0xd1, 0x90, 0x15, 0x76, 0x14, 0x01, 0x00} }, SZ_2K, SZ_128, SZ_128K, 0, 8, 64, NAND_ECC_INFO(1, SZ_512), }, - {"TC58NVG0S3HTA00 1G 3.3V 8-bit", - { .id = {0x98, 0xf1, 0x80, 0x15} }, - SZ_2K, SZ_128, SZ_128K, 0, 4, 128, NAND_ECC_INFO(8, SZ_512), }, {"TC58NVG2S0F 4G 3.3V 8-bit", { .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08} }, SZ_4K, SZ_512, SZ_256K, 0, 8, 224, NAND_ECC_INFO(4, SZ_512) },
This reverts commit 3380557fc7e28d9bce7607e16d98f123d36da4ca. It turned out this "4-byte" ID might have been an honest mistake. Regrettably, the chip Andreas has might be a counterfeit or is damaged in some other way and shouldn't have ended up in a router. Andreas reported his chip is returning just four bytes: "98 f1 80 15 00 00 00 00". However, according to Kioxia/Toshiba's datasheet, there should have been at least another byte that would have contained the correct OOB size that Andreas needed. Thanks to Peter-vdL for reporting this issue and Hannu Nyman as well as neg2led who did the debugging. Cc: Andreas B<C3><B6>hler <dev@aboehler.at> BugLink: https://github.com/openwrt/openwrt/issues/9962 Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- drivers/mtd/nand/raw/nand_ids.c | 3 --- 1 file changed, 3 deletions(-)