Message ID | 20220603135933.143372-1-tom@tom-fitzhenry.me.uk |
---|---|
State | Superseded |
Delegated to: | Pratyush Yadav |
Headers | show |
Series | mtd: spi-nor: siliconkaiser: add support for sk25lp128 | expand |
Sorry, I've just noticed that this patch fails checkpatch.pl. I will fix this and send a v2 shortly.
Hi Tom, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/spi-nor/next] [also build test ERROR on v5.19-rc1 next-20220607] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Tom-Fitzhenry/mtd-spi-nor-siliconkaiser-add-support-for-sk25lp128/20220605-163120 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next config: csky-randconfig-r024-20220607 (https://download.01.org/0day-ci/archive/20220608/202206081011.jPVWbSvo-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/9ee4927880d43f8611d371e7cc7d8854a927de66 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Tom-Fitzhenry/mtd-spi-nor-siliconkaiser-add-support-for-sk25lp128/20220605-163120 git checkout 9ee4927880d43f8611d371e7cc7d8854a927de66 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash drivers/mtd/spi-nor/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: implicit declaration of function 'SNOR_ID3' [-Werror=implicit-function-declaration] 8 | { "sk25lp128", SNOR_ID3(0x257018) }, | ^~~~~~~~ >> drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: initializer element is not constant drivers/mtd/spi-nor/siliconkaiser.c:8:18: note: (near initialization for 'siliconkaiser_nor_parts[0].id[0]') cc1: some warnings being treated as errors vim +/SNOR_ID3 +8 drivers/mtd/spi-nor/siliconkaiser.c 6 7 static const struct flash_info siliconkaiser_nor_parts[] = { > 8 { "sk25lp128", SNOR_ID3(0x257018) }, 9 }; 10
Hi Tom, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mtd/spi-nor/next] [also build test WARNING on v5.19-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Tom-Fitzhenry/mtd-spi-nor-siliconkaiser-add-support-for-sk25lp128/20220605-163120 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next config: arm-randconfig-c002-20220607 (https://download.01.org/0day-ci/archive/20220609/202206090308.3aMXmhee-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/9ee4927880d43f8611d371e7cc7d8854a927de66 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Tom-Fitzhenry/mtd-spi-nor-siliconkaiser-add-support-for-sk25lp128/20220605-163120 git checkout 9ee4927880d43f8611d371e7cc7d8854a927de66 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/mtd/spi-nor/ drivers/nfc/nfcmrvl/ fs/quota/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: call to undeclared function 'SNOR_ID3'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] { "sk25lp128", SNOR_ID3(0x257018) }, ^ >> drivers/mtd/spi-nor/siliconkaiser.c:8:18: warning: suggest braces around initialization of subobject [-Wmissing-braces] { "sk25lp128", SNOR_ID3(0x257018) }, ^~~~~~~~~~~~~~~~~~ { } drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: initializer element is not a compile-time constant { "sk25lp128", SNOR_ID3(0x257018) }, ^~~~~~~~~~~~~~~~~~ 1 warning and 2 errors generated. vim +8 drivers/mtd/spi-nor/siliconkaiser.c 6 7 static const struct flash_info siliconkaiser_nor_parts[] = { > 8 { "sk25lp128", SNOR_ID3(0x257018) }, 9 }; 10
Hi Tom, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/spi-nor/next] [also build test ERROR on v5.19-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Tom-Fitzhenry/mtd-spi-nor-siliconkaiser-add-support-for-sk25lp128/20220605-163120 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next config: arm-randconfig-c002-20220607 (https://download.01.org/0day-ci/archive/20220609/202206090649.QxcEHXEj-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/9ee4927880d43f8611d371e7cc7d8854a927de66 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Tom-Fitzhenry/mtd-spi-nor-siliconkaiser-add-support-for-sk25lp128/20220605-163120 git checkout 9ee4927880d43f8611d371e7cc7d8854a927de66 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/mtd/ drivers/nfc/ fs/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: call to undeclared function 'SNOR_ID3'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] { "sk25lp128", SNOR_ID3(0x257018) }, ^ drivers/mtd/spi-nor/siliconkaiser.c:8:18: warning: suggest braces around initialization of subobject [-Wmissing-braces] { "sk25lp128", SNOR_ID3(0x257018) }, ^~~~~~~~~~~~~~~~~~ { } >> drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: initializer element is not a compile-time constant { "sk25lp128", SNOR_ID3(0x257018) }, ^~~~~~~~~~~~~~~~~~ 1 warning and 2 errors generated. vim +/SNOR_ID3 +8 drivers/mtd/spi-nor/siliconkaiser.c 6 7 static const struct flash_info siliconkaiser_nor_parts[] = { > 8 { "sk25lp128", SNOR_ID3(0x257018) }, 9 }; 10
diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile index e347b435a038..314ac7773369 100644 --- a/drivers/mtd/spi-nor/Makefile +++ b/drivers/mtd/spi-nor/Makefile @@ -12,6 +12,7 @@ spi-nor-objs += intel.o spi-nor-objs += issi.o spi-nor-objs += macronix.o spi-nor-objs += micron-st.o +spi-nor-objs += siliconkaiser.o spi-nor-objs += spansion.o spi-nor-objs += sst.o spi-nor-objs += winbond.o diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index fdde80d9f388..e542d3009915 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -1624,6 +1624,7 @@ static const struct spi_nor_manufacturer *manufacturers[] = { &spi_nor_issi, &spi_nor_macronix, &spi_nor_micron, + &spi_nor_siliconkaiser, &spi_nor_st, &spi_nor_spansion, &spi_nor_sst, diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 87183cff3251..8997099f6c5e 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -625,6 +625,7 @@ extern const struct spi_nor_manufacturer spi_nor_intel; extern const struct spi_nor_manufacturer spi_nor_issi; extern const struct spi_nor_manufacturer spi_nor_macronix; extern const struct spi_nor_manufacturer spi_nor_micron; +extern const struct spi_nor_manufacturer spi_nor_siliconkaiser; extern const struct spi_nor_manufacturer spi_nor_st; extern const struct spi_nor_manufacturer spi_nor_spansion; extern const struct spi_nor_manufacturer spi_nor_sst; diff --git a/drivers/mtd/spi-nor/siliconkaiser.c b/drivers/mtd/spi-nor/siliconkaiser.c new file mode 100644 index 000000000000..82bb6094caa9 --- /dev/null +++ b/drivers/mtd/spi-nor/siliconkaiser.c @@ -0,0 +1,15 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include <linux/mtd/spi-nor.h> + +#include "core.h" + +static const struct flash_info siliconkaiser_nor_parts[] = { + { "sk25lp128", SNOR_ID3(0x257018) }, +}; + +const struct spi_nor_manufacturer spi_nor_siliconkaiser = { + .name = "siliconkaiser", + .parts = siliconkaiser_nor_parts, + .nparts = ARRAY_SIZE(siliconkaiser_nor_parts), +};
Add support for the siliconkaiser sk25lp128 chip. This is the flash chip used in the PinePhone Pro[0], found by physical inspection of the board.[1] I cannot find a datasheet, but this chip supports SFDP. This patch depends on SNOR_ID3().[2] https://lore.kernel.org/all/20220510140232.3519184-1-michael@walle.cc/ Tested done: checked that the Pinephone Pro boots when a ROM is written to /dev/mtdblock0. $ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 53464450060101ff00060110300000ff9d05010380000002ffffffffffff ffffffffffffffffffffffffffffffffffffe520f9ffffffff0744eb086b 083b80bbfeffffffffff00ffffff44eb0c200f5210d800ff234ac90082d8 11c7cccd68467a757a75f7a2d55c4a422cfff030c080ffffffffffffffff ffffffffffffffff501950169cf9c0648fecffff $ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp de4d6be54e479d60859b0ca8a0ee9216 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp $ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id 257018 $ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname sk25lp128 $ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer siliconkaiser 0. https://wiki.pine64.org/wiki/PinePhone_Pro#Specifications 1. Thanks to https://github.com/Biktorgj for finding that. 2. "mtd: spi-nor: introduce SNOR_ID3()" https://lore.kernel.org/all/20220510140232.3519184-1-michael@walle.cc/ Link: https://lore.kernel.org/all/20220510140232.3519184-1-michael@walle.cc/ Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk> --- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/core.c | 1 + drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/siliconkaiser.c | 15 +++++++++++++++ 4 files changed, 18 insertions(+) create mode 100644 drivers/mtd/spi-nor/siliconkaiser.c