| Message ID | 20220325123707.22020-3-rogerq@kernel.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | mtd: rawnand: omap_elm: convert DT binding to yaml | expand |
On 25/03/2022 13:37, Roger Quadros wrote: > TI's AM64 SoC has the Error Locator Module. Add compatible and > related properties to support ELM on AM64 SoC. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > .../devicetree/bindings/mtd/ti,elm.yaml | 28 ++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml > index e36452b742c0..967c87f32c71 100644 > --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml > +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml > @@ -16,7 +16,10 @@ description: > > properties: > compatible: > - const: ti,am3352-elm > + items: Why do the items appeared again? Make it an enum in first patch, without items, with one entry. Now in patch #2 you add one more compatible. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml index e36452b742c0..967c87f32c71 100644 --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml @@ -16,7 +16,10 @@ description: properties: compatible: - const: ti,am3352-elm + items: + - enum: + - ti,am3352-elm + - ti,am64-elm reg: maxItems: 1 @@ -24,6 +27,17 @@ properties: interrupts: maxItems: 1 + clocks: + maxItems: 1 + description: Functional clock. + + clock-names: + items: + - const: fck + + power-domains: + maxItems: 1 + ti,hwmods: description: Name of the HWMOD associated with ELM. This is for legacy @@ -36,6 +50,18 @@ required: - reg - interrupts +allOf: + - if: + properties: + compatible: + contains: + const: ti,am64-elm + then: + required: + - clocks + - clock-names + - power-domains + additionalProperties: false examples:
TI's AM64 SoC has the Error Locator Module. Add compatible and related properties to support ELM on AM64 SoC. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- .../devicetree/bindings/mtd/ti,elm.yaml | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)