diff mbox series

[v4,3/3] spi: dt-bindings: Add an example with two stacked flashes

Message ID 20211210201039.729961-4-miquel.raynal@bootlin.com
State Changes Requested
Headers show
Series Stacked/parallel memories bindings | expand

Commit Message

Miquel Raynal Dec. 10, 2021, 8:10 p.m. UTC
Provide an example of how to describe two flashes in eg. stacked mode.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/spi/spi-controller.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Rob Herring (Arm) Dec. 14, 2021, 5:37 p.m. UTC | #1
On Fri, Dec 10, 2021 at 09:10:39PM +0100, Miquel Raynal wrote:
> Provide an example of how to describe two flashes in eg. stacked mode.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/spi/spi-controller.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> index 36b72518f565..048d2bbc74a5 100644
> --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> @@ -139,4 +139,11 @@ examples:
>              spi-max-frequency = <100000>;
>              reg = <1>;
>          };
> +
> +        flash@2 {
> +          compatible = "jedec,spi-nor";
> +          spi-max-frequency = <50000000>;
> +          reg = <2>, <3>;
> +          stacked-memories = /bits/ 64 <0x10000000>, /bits/ 64 <0x10000000>;

stacked-memories = /bits/ 64 <0x10000000 0x10000000>;

While the source syntax allows for multiple (and mixed) /bits/ 
annotations, that's not something we support really.

If you have problems with the schema tools on this, let me know. The 
handling of this is not the greatest.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
index 36b72518f565..048d2bbc74a5 100644
--- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
@@ -139,4 +139,11 @@  examples:
             spi-max-frequency = <100000>;
             reg = <1>;
         };
+
+        flash@2 {
+          compatible = "jedec,spi-nor";
+          spi-max-frequency = <50000000>;
+          reg = <2>, <3>;
+          stacked-memories = /bits/ 64 <0x10000000>, /bits/ 64 <0x10000000>;
+        };
     };