| Message ID | 20211102172604.2921065-1-andreas.oetken@siemens-energy.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] drivers: mtd: Fixed breaking list in __mtd_del_partition. | expand |
On Tue, 2021-11-02 at 17:26:04 UTC, Andreas Oetken wrote: > Not the child partition should be removed from the partition list > but the partition itself. Otherwise the partition list gets broken > and any subsequent remove operations leads to a kernel panic. > > Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling") > Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com> > Cc: stable@vger.kernel.org Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index 95d47422bbf20..5725818fa199f 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mtd_info *mtd) if (err) return err; - list_del(&child->part.node); + list_del(&mtd->part.node); free_partition(mtd); return 0;
Not the child partition should be removed from the partition list but the partition itself. Otherwise the partition list gets broken and any subsequent remove operations leads to a kernel panic. Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling") Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com> Cc: stable@vger.kernel.org --- drivers/mtd/mtdpart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)