| Message ID | 20211012090224.4101984-1-s.riedmueller@phytec.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [RFC,1/2] mtd: rawnand: gpmi: Remove explicit default gpmi clock setting for i.MX6 | expand |
On Tuesday, 12 October 2021, 11:02:23 CEST, Stefan Riedmueller wrote: > There is no need to explicitly set the default gpmi clock rate during > boot for the i.MX 6 since this is done during nand_detect anyway. > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> > --- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > index 4d08e4ab5c1b..a1f7000f033e 100644 > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > @@ -1034,15 +1034,6 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) > r->clock[i] = clk; > } > > - if (GPMI_IS_MX6(this)) > - /* > - * Set the default value for the gpmi clock. > - * > - * If you want to use the ONFI nand which is in the > - * Synchronous Mode, you should change the clock as you need. > - */ > - clk_set_rate(r->clock[0], 22000000); > - > return 0; > > err_clock: > Tested-by: Christian Eggers <ceggers@arri.de> # on i.MX6ULL with MT29F4G08ABADAH4 Cc: stable@vger.kernel.org
diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c index 4d08e4ab5c1b..a1f7000f033e 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c @@ -1034,15 +1034,6 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) r->clock[i] = clk; } - if (GPMI_IS_MX6(this)) - /* - * Set the default value for the gpmi clock. - * - * If you want to use the ONFI nand which is in the - * Synchronous Mode, you should change the clock as you need. - */ - clk_set_rate(r->clock[0], 22000000); - return 0; err_clock:
There is no need to explicitly set the default gpmi clock rate during boot for the i.MX 6 since this is done during nand_detect anyway. Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> --- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 9 --------- 1 file changed, 9 deletions(-)