From patchwork Tue Jul 27 04:51:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 1510292 X-Patchwork-Delegate: tudor.ambarus@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=W45yHUZ9; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=microchip.com header.i=@microchip.com header.a=rsa-sha256 header.s=mchp header.b=jxiyHxrd; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GYlZP0blRz9sWl for ; Tue, 27 Jul 2021 15:23:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1IwkUwh829KZTgcbRE7uJq5ZngtN+36DY9hr1LRC+w0=; b=W45yHUZ9UWBkE+ ZfbAdskJ6FTp/ehQ3thIsi/CwReo9HXu80TYIlg57oStzypJJ0jKEojD4weuarb2OSY+HXhohCzF5 wrFHu0ipQX/wJKkRoqHQ++IuWD+FnThQtn3oE+Pr/mgiPJM6CfHxFHNLoli/g+Po1QC/PPK5tlQv0 gwgLyo+jyvkf/uiqIM+BgUskpcUUzz9hZdawpqzXv9hYvcV5PkRjV8ASnGUe92qqjhlOJdGJjqlQ/ Fnp8Txa7/CrmyEFTVYsohNlTlTIFzTg5ThNiO/v2JW8d3B7L3x5uT0Wv4903sZwhWBT+ktLYrFaHC VcyZMn5ifszcMCkw4iRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8FYR-00DPWD-Va; Tue, 27 Jul 2021 05:23:00 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8F5x-00DHcL-2z; Tue, 27 Jul 2021 04:53:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1627361613; x=1658897613; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YlTavZcPTLHLDyRR/4iV9l7Py9LfBh5YVJy1QKVoG7o=; b=jxiyHxrdIblb4iy2V4ab5C5U70bAgYQ+KlUUUM90hrQ17v8A4bNQvgW8 9iPGkeu6tak3oBrxdkTY58HTg/BFDhtQw0KmsQlHcJz3dSSEf5W80v9Lw 7BpMaYRae54Arl0fP+vitCjiciKbUaxk+KHYSKrHivdYciFLnX3TaCKfH oVGa2xNMc1YT9tr2JHPUHBMkToePZ7mVScCgRkzCw2XbNX6bhMnGoPGKn imhqaui9WzeyFgkUWXLfLrPgw/XzY0b6dLc19JXX5znbUyM6z4gbDxKUe QncG9pUX8WRmZ5lRSDNbXOah5DEeh+A5eCFxTfx49VMK9VlFoIdLlCh0z A==; IronPort-SDR: /VYiasdu+SLELpP72wQJyygMl2TZSycTJsXIse9gyAoOc6TdRogbFOh+4QX2WzQLcp9l2wt+/u CFIGum3pg+djY0WrqxLaSU85qw8Gd54eccFooNnGjWiqmikc5k3LFVjmSGUKEvXCoLWlQfsUT/ v91/biL+FCDmCDQ6rsk9ZLTYefsSgCOx0er1yqQVDQMLe0P9/VAdOOuaLJ0TiUOTW1rqIrL27O DOqerhPtVuF0J0gBWkNIH3wvDR951teDuyJZbudQt8BONeoTlrgD4Tzu6VRGonuHOeoECIwx/K 9N6T1iHqKGwBntvIzgN1fhIg X-IronPort-AV: E=Sophos;i="5.84,272,1620716400"; d="scan'208";a="126055047" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 26 Jul 2021 21:53:32 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 26 Jul 2021 21:53:30 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Mon, 26 Jul 2021 21:53:26 -0700 From: Tudor Ambarus To: , , CC: , , , , , , , , , , , , , , , , "Tudor Ambarus" Subject: [PATCH v2 12/35] mtd: spi-nor: xilinx: Use manufacturer late_init() to set setup method Date: Tue, 27 Jul 2021 07:51:59 +0300 Message-ID: <20210727045222.905056-13-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210727045222.905056-1-tudor.ambarus@microchip.com> References: <20210727045222.905056-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_215333_253738_0BBBD7AF X-CRM114-Status: GOOD ( 10.17 ) X-Spam-Score: -2.7 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: post_sfdp was misleading in this case, as SFDP is not supported by xilinx. Plus, there's no fixup here, just setting the correct setup method, as required by xilinx parts. Signed-off-by: Tudor Ambarus --- drivers/mtd/spi-nor/xilinx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) Content analysis details: (-2.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [68.232.154.123 listed in wl.mailspike.net] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.154.123 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org post_sfdp was misleading in this case, as SFDP is not supported by xilinx. Plus, there's no fixup here, just setting the correct setup method, as required by xilinx parts. Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav Reviewed-by: Michael Walle --- drivers/mtd/spi-nor/xilinx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/spi-nor/xilinx.c b/drivers/mtd/spi-nor/xilinx.c index 1138bdbf4199..a573c3cde414 100644 --- a/drivers/mtd/spi-nor/xilinx.c +++ b/drivers/mtd/spi-nor/xilinx.c @@ -77,18 +77,14 @@ static int xilinx_nor_setup(struct spi_nor *nor, return 0; } -static void xilinx_post_sfdp_fixups(struct spi_nor *nor) +static void xilinx_late_init(struct spi_nor *nor) { nor->params->setup = xilinx_nor_setup; } -static const struct spi_nor_fixups xilinx_fixups = { - .post_sfdp = xilinx_post_sfdp_fixups, -}; - const struct spi_nor_manufacturer spi_nor_xilinx = { .name = "xilinx", .parts = xilinx_parts, .nparts = ARRAY_SIZE(xilinx_parts), - .fixups = &xilinx_fixups, + .late_init = xilinx_late_init, };