| Message ID | 20210727045222.905056-13-tudor.ambarus@microchip.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: Handle ID collisions and clean params init | expand |
On 27/07/21 07:51AM, Tudor Ambarus wrote: > post_sfdp was misleading in this case, as SFDP is not supported by > xilinx. Plus, there's no fixup here, just setting the correct > setup method, as required by xilinx parts. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Reviewed-by: Pratyush Yadav <p.yadav@ti.com> > --- > drivers/mtd/spi-nor/xilinx.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/spi-nor/xilinx.c b/drivers/mtd/spi-nor/xilinx.c > index 1138bdbf4199..a573c3cde414 100644 > --- a/drivers/mtd/spi-nor/xilinx.c > +++ b/drivers/mtd/spi-nor/xilinx.c > @@ -77,18 +77,14 @@ static int xilinx_nor_setup(struct spi_nor *nor, > return 0; > } > > -static void xilinx_post_sfdp_fixups(struct spi_nor *nor) > +static void xilinx_late_init(struct spi_nor *nor) > { > nor->params->setup = xilinx_nor_setup; > } > > -static const struct spi_nor_fixups xilinx_fixups = { > - .post_sfdp = xilinx_post_sfdp_fixups, > -}; > - > const struct spi_nor_manufacturer spi_nor_xilinx = { > .name = "xilinx", > .parts = xilinx_parts, > .nparts = ARRAY_SIZE(xilinx_parts), > - .fixups = &xilinx_fixups, > + .late_init = xilinx_late_init, > }; > -- > 2.25.1 >
Am 2021-07-27 06:51, schrieb Tudor Ambarus: > post_sfdp was misleading in this case, as SFDP is not supported by > xilinx. Plus, there's no fixup here, just setting the correct > setup method, as required by xilinx parts. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Reviewed-by: Michael Walle <michael@walle.cc>
diff --git a/drivers/mtd/spi-nor/xilinx.c b/drivers/mtd/spi-nor/xilinx.c index 1138bdbf4199..a573c3cde414 100644 --- a/drivers/mtd/spi-nor/xilinx.c +++ b/drivers/mtd/spi-nor/xilinx.c @@ -77,18 +77,14 @@ static int xilinx_nor_setup(struct spi_nor *nor, return 0; } -static void xilinx_post_sfdp_fixups(struct spi_nor *nor) +static void xilinx_late_init(struct spi_nor *nor) { nor->params->setup = xilinx_nor_setup; } -static const struct spi_nor_fixups xilinx_fixups = { - .post_sfdp = xilinx_post_sfdp_fixups, -}; - const struct spi_nor_manufacturer spi_nor_xilinx = { .name = "xilinx", .parts = xilinx_parts, .nparts = ARRAY_SIZE(xilinx_parts), - .fixups = &xilinx_fixups, + .late_init = xilinx_late_init, };
post_sfdp was misleading in this case, as SFDP is not supported by xilinx. Plus, there's no fixup here, just setting the correct setup method, as required by xilinx parts. Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> --- drivers/mtd/spi-nor/xilinx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)