| Message ID | 20210615140652.59521-1-colin.king@canonical.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [next] mtd: devices: mchp48l640: Fix return of uninitialized value in ret | expand |
Hello Colin, On 15.06.21 16:06, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > In the case where the read or write lengths are zero bytes the return > value in variable ret has not been initialized and a garbage value > is returned. Fix this by initializing ret to zero. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/mtd/devices/mchp48l640.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks! Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko
diff --git a/drivers/mtd/devices/mchp48l640.c b/drivers/mtd/devices/mchp48l640.c index efc2003bd13a..0833f41e9d17 100644 --- a/drivers/mtd/devices/mchp48l640.c +++ b/drivers/mtd/devices/mchp48l640.c @@ -210,7 +210,7 @@ static int mchp48l640_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, const unsigned char *buf) { struct mchp48l640_flash *flash = to_mchp48l640_flash(mtd); - int ret; + int ret = 0; size_t wlen = 0; loff_t woff = to; size_t ws; @@ -267,7 +267,7 @@ static int mchp48l640_read(struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, unsigned char *buf) { struct mchp48l640_flash *flash = to_mchp48l640_flash(mtd); - int ret; + int ret = 0; size_t wlen = 0; loff_t woff = from; size_t ws;