Message ID | 20210413161840.345208-4-miquel.raynal@bootlin.com |
---|---|
State | Accepted |
Headers | show |
Series | Fix use of Hamming helpers | expand |
On 4/13/21 7:18 PM, Miquel Raynal wrote: > Since the Hamming software ECC engine has been updated to become a > proper and independent ECC engine, it is now mandatory to either > initialize the engine before using any one of his functions or use one > of the bare helpers which only perform the calculations. As there is no > actual need for a proper ECC initialization, let's just use the bare > helper instead of the rawnand one. > > Fixes: 90ccf0a0192f ("mtd: nand: ecc-hamming: Rename the exported functions") > Cc: stable@vger.kernel.org > Cc: Vladimir Zapolskiy <vz@mleia.com> > Reported-by: Trevor Woerner <twoerner@gmail.com> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Tested-by: Trevor Woerner <twoerner@gmail.com> Acked-by: Vladimir Zapolskiy <vz@mleia.com> -- Best wishes, Vladimir
On Tue, 2021-04-13 at 16:18:36 UTC, Miquel Raynal wrote: > Since the Hamming software ECC engine has been updated to become a > proper and independent ECC engine, it is now mandatory to either > initialize the engine before using any one of his functions or use one > of the bare helpers which only perform the calculations. As there is no > actual need for a proper ECC initialization, let's just use the bare > helper instead of the rawnand one. > > Fixes: 90ccf0a0192f ("mtd: nand: ecc-hamming: Rename the exported functions") > Cc: stable@vger.kernel.org > Cc: Vladimir Zapolskiy <vz@mleia.com> > Reported-by: Trevor Woerner <twoerner@gmail.com> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Tested-by: Trevor Woerner <twoerner@gmail.com> > Acked-by: Vladimir Zapolskiy <vz@mleia.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes. Miquel
diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c index 6b7269cfb7d8..d7dfc6fd85ca 100644 --- a/drivers/mtd/nand/raw/lpc32xx_slc.c +++ b/drivers/mtd/nand/raw/lpc32xx_slc.c @@ -27,6 +27,7 @@ #include <linux/of.h> #include <linux/of_gpio.h> #include <linux/mtd/lpc32xx_slc.h> +#include <linux/mtd/nand-ecc-sw-hamming.h> #define LPC32XX_MODNAME "lpc32xx-nand" @@ -344,6 +345,18 @@ static int lpc32xx_nand_ecc_calculate(struct nand_chip *chip, return 0; } +/* + * Corrects the data + */ +static int lpc32xx_nand_ecc_correct(struct nand_chip *chip, + unsigned char *buf, + unsigned char *read_ecc, + unsigned char *calc_ecc) +{ + return ecc_sw_hamming_correct(buf, read_ecc, calc_ecc, + chip->ecc.size, false); +} + /* * Read a single byte from NAND device */ @@ -802,7 +815,7 @@ static int lpc32xx_nand_attach_chip(struct nand_chip *chip) chip->ecc.write_oob = lpc32xx_nand_write_oob_syndrome; chip->ecc.read_oob = lpc32xx_nand_read_oob_syndrome; chip->ecc.calculate = lpc32xx_nand_ecc_calculate; - chip->ecc.correct = rawnand_sw_hamming_correct; + chip->ecc.correct = lpc32xx_nand_ecc_correct; chip->ecc.hwctl = lpc32xx_nand_ecc_enable; /*