| Message ID | 20200721151657.41027-1-weiyongjun1@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | [-next] mtd: rawnand: pasemi: Make pasemi_device_ready() static | expand |
On Tue, 2020-07-21 at 15:16:57 UTC, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/mtd/nand/raw/pasemi_nand.c:71:5: warning: > symbol 'pasemi_device_ready' was not declared. Should it be static? > > This function is not used outside of pasemi_nand.c, so this commit > marks it static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
diff --git a/drivers/mtd/nand/raw/pasemi_nand.c b/drivers/mtd/nand/raw/pasemi_nand.c index d8eca8c3fdcd..81e2e667037e 100644 --- a/drivers/mtd/nand/raw/pasemi_nand.c +++ b/drivers/mtd/nand/raw/pasemi_nand.c @@ -68,7 +68,7 @@ static void pasemi_hwcontrol(struct nand_chip *chip, int cmd, inl(lpcctl); } -int pasemi_device_ready(struct nand_chip *chip) +static int pasemi_device_ready(struct nand_chip *chip) { return !!(inl(lpcctl) & LBICTRL_LPCCTL_NR); }
The sparse tool complains as follows: drivers/mtd/nand/raw/pasemi_nand.c:71:5: warning: symbol 'pasemi_device_ready' was not declared. Should it be static? This function is not used outside of pasemi_nand.c, so this commit marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/mtd/nand/raw/pasemi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)