| Message ID | 20190312104549.22721-1-geert+renesas@glider.be |
|---|---|
| State | Accepted |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: Print all JEDEC ID bytes on error | expand |
On 03/12/2019 12:45 PM, Geert Uytterhoeven wrote: > If identification of an SPI NOR FLASH fails, the JEDEC ID is printed, > which is stored in the first 3 bytes of the ID read from the FLASH. > However, the extended JEDEC ID, which is stored in the remaining bytes, > also matters, as it is used for identification of some FLASH types. > > Print all (currently 6) ID bytes read to ease failure analysis and > debugging. > > Suggested-by: Tudor Ambarus <tudor.ambarus@microchip.com> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index fae147452aff3499..028b21abee0da5dc 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2071,8 +2071,8 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor) > return &spi_nor_ids[tmp]; > } > } > - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n", > - id[0], id[1], id[2]); > + dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n", > + SPI_NOR_MAX_ID_LEN, id); > return ERR_PTR(-ENODEV); > } > >
On 03/12/2019 12:45 PM, Geert Uytterhoeven wrote: > If identification of an SPI NOR FLASH fails, the JEDEC ID is printed, > which is stored in the first 3 bytes of the ID read from the FLASH. > However, the extended JEDEC ID, which is stored in the remaining bytes, > also matters, as it is used for identification of some FLASH types. > > Print all (currently 6) ID bytes read to ease failure analysis and > debugging. > > Suggested-by: Tudor Ambarus <tudor.ambarus@microchip.com> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/mtd/spi-nor/spi-nor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to http://git.infradead.org/linux-mtd.git, spi-nor/next. Thanks.
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index fae147452aff3499..028b21abee0da5dc 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2071,8 +2071,8 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor) return &spi_nor_ids[tmp]; } } - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n", - id[0], id[1], id[2]); + dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n", + SPI_NOR_MAX_ID_LEN, id); return ERR_PTR(-ENODEV); }
If identification of an SPI NOR FLASH fails, the JEDEC ID is printed, which is stored in the first 3 bytes of the ID read from the FLASH. However, the extended JEDEC ID, which is stored in the remaining bytes, also matters, as it is used for identification of some FLASH types. Print all (currently 6) ID bytes read to ease failure analysis and debugging. Suggested-by: Tudor Ambarus <tudor.ambarus@microchip.com> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/mtd/spi-nor/spi-nor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)