From patchwork Fri Nov 9 17:40:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 995691 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=microchip.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aq9nK8zF"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="Dj4MNjBF"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="d5H5cfjC"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42s6rN0m3rz9s8J for ; Sat, 10 Nov 2018 04:40:52 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:Message-ID:Date :Subject:To:From:Reply-To:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Q6Q6CWSjUQ7qts8XWn+GkvV3ZvmbjMKAMZjuefEZ1/o=; b=aq9nK8zFNzdD1m NeYoAMxxsAHYgg0n7eqSVOUCWio84cJwm7XNF2PC3x6k1Zzfy1z7ylN7MSBxEoUFEnelFltVvw5FE toRdx7tl3eh8106Hv3wG6VLBPG1yuQhsRS16BgiKC84GWiDzsHdxCSfWIZp6N6PdvOyUHobaDaLmX eZcryTxaW2gfIVtWBe6wwZ0OS+/k1Jx8gj6GTqACr7dltCIVkF7Qhtb/0H4Nan9lh4M/NKLxDkoIl pebMTvNEDY0egY+Wts6vmN+jJFfd6LdjyG4oQW4PRuaZiHbW0gRVC9DlSSBlCCO8Ai2mS+RHp/4Sl O6vD8zLdXsmJQBPW0s8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gLAlt-0007Ej-U8; Fri, 09 Nov 2018 17:40:41 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gLAls-0007Ec-12 for linux-mtd@bombadil.infradead.org; Fri, 09 Nov 2018 17:40:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=MIME-Version:Content-Transfer-Encoding: Content-ID:Content-Type:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Lq8LLtxyLa8nCWFDRY6stJMonGTHgVC6Lg4djPf8yJY=; b=Dj4MNjBFWXVyx4rR7TzXnL2JlH YqyLvHRB8tsYVgyk/oFrHm6L6DJT9SJs5KXFPfjMC0G/LyKhUlXxCzbLJFS2XcIdIT+GFzW7T5foI 3nU+5CnR2MHM8K4aZnR1J4xxRHVM6nqIEOYFycWUWZ67NcJNMTolSjAPBg7mcHuIJvjkqCgmszYJt iGTcEchr3yj72HVZCsg0RnxM2wY9odLsVJ6JEDx+sda0XvRG3hCPCp3wCpqlPByemvW+CNX2MUVue mslYU6vxUMFPvYnjs9d1SQLhBf72NkGzcNYoQoM890Y0fNgbmgHey1+u5PEHmfsy4egq3Wrh9Li5A 9uf7ue+g==; Received: from esa3.microchip.iphmx.com ([68.232.153.233]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gLAlp-0006VD-D8 for linux-mtd@lists.infradead.org; Fri, 09 Nov 2018 17:40:38 +0000 X-IronPort-AV: E=Sophos;i="5.54,483,1534834800"; d="scan'208";a="23077348" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Nov 2018 10:40:25 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.49) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 9 Nov 2018 10:40:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lq8LLtxyLa8nCWFDRY6stJMonGTHgVC6Lg4djPf8yJY=; b=d5H5cfjCTU+sCND3iBHYFRAytDwtZGL6ED8V5fIo7t+h5O1fh/z+IuiBGvG1Eh5iNmHHeG4g6yZU4F9Osh9FCwNN05fC/CPe/iZN10MPHICG5bXEy2XUE2CbSlO3A1cKzefqAxJe4H9gNhJ2LeY/xFpmfkef/MJiHa0jsWMULIA= Received: from BN6PR11MB1842.namprd11.prod.outlook.com (10.175.99.146) by BN6PR11MB1955.namprd11.prod.outlook.com (10.175.100.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Fri, 9 Nov 2018 17:40:21 +0000 Received: from BN6PR11MB1842.namprd11.prod.outlook.com ([fe80::11b7:21db:803a:7cfa]) by BN6PR11MB1842.namprd11.prod.outlook.com ([fe80::11b7:21db:803a:7cfa%5]) with mapi id 15.20.1294.034; Fri, 9 Nov 2018 17:40:21 +0000 From: To: , , , , Subject: [PATCH] mtd: spi-nor: mark desirable switch case fall through Thread-Topic: [PATCH] mtd: spi-nor: mark desirable switch case fall through Thread-Index: AQHUeFNJm6LH43gO+0eRZHpCMxJGwA== Date: Fri, 9 Nov 2018 17:40:21 +0000 Message-ID: <20181109174017.19269-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR07CA0254.eurprd07.prod.outlook.com (2603:10a6:803:b4::21) To BN6PR11MB1842.namprd11.prod.outlook.com (2603:10b6:404:103::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tudor.Ambarus@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR11MB1955; 6:rG0COFoLKGjBrmFWypNmt2wVicLxA8QfsglR0yG362gLKrxhPmluv4u+HXvoKljZaBnBJlsFW40dToPZ2Sa/WYDofNAfbM8kXydI0Dup6iXEGMx365uOPS4/za9xRis/pypJdFU6hjG/0RGtD9WS+eBD2RsuQgd7lp/+cAKJQiJoZgUpaZ3Ef5Vxd9dDA4VpZcVnmBg3c3B44WtJJRg5bCo0FqtnUtJrLvwugZoQMcQF/md9YTpub/sgR/pGFQdfr00qhb8SU3lFBZgyZLqNXWWo2XF/Tz5+WSbipMeytDiZQhuMWszYp6IGNwELdFon0f+Yy8jM9gLlDBMcSzTr3KRtg6mf5SBbV2pRthQybnFtujHQG0eumYjPrmkQazUdqb2oC4KuMl38BqN9C8a5k3XHRlu4KPAedudGVwXH2yVg9d6PaWe2a2j+gfifLVUrK8w66jXt43RlPZW3B9Ez+A==; 5:fiP/asU1XSd74hnu6NoGtuKOx/gMG7ngG6uonjzv2xXc4+8E4baxeTJ6GFb22gCtBDo7JuROF7S7P+73oS0SJ9/qWLxlk2MY8c2QAvixBEeLJLMHP9ZW2+oOZySLDExg5FQwawY7gMLPw6QQrA2cW1RBs1n6AaCP7fGv+9yz7uk=; 7:eoGZq4ZTTMCO3FGHKdexipm0UEWI1vv4O3ve6Fx9JmDp4IZz7bDxSX0zaYI2XBABt/ryiGvUJYnb/oOuayVUjwx1JddWKjHB1M/7R1M/zMSgpBCDLFUDZ7WUXlcxb5AiYfjowwWKniDcaqPh85mkUw== x-ms-office365-filtering-correlation-id: c6ee66f8-722b-4a6b-581d-08d6466a6b84 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BN6PR11MB1955; x-ms-traffictypediagnostic: BN6PR11MB1955: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:BN6PR11MB1955; BCL:0; PCL:0; RULEID:; SRVR:BN6PR11MB1955; x-forefront-prvs: 08512C5403 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(52116002)(25786009)(71190400001)(86362001)(72206003)(256004)(14444005)(99286004)(8936002)(81156014)(81166006)(36756003)(8676002)(97736004)(71200400001)(68736007)(186003)(110136005)(39060400002)(478600001)(5660300001)(386003)(1857600001)(105586002)(26005)(106356001)(2900100001)(6506007)(54906003)(102836004)(316002)(6486002)(6436002)(486006)(305945005)(4326008)(2501003)(7736002)(6512007)(107886003)(6116002)(3846002)(2906002)(1076002)(14454004)(53936002)(66066001)(2201001)(476003)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR11MB1955; H:BN6PR11MB1842.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: avQTT8a1fnBAnKt21V0JI9eeCU+JgSVXzuCzYPPo7bISiR6LW2GEvCXi97DbS37usmQMiEVIb6mAJZTlZaKu//N1wgRxOA6cy8IUsxrf8iLg7VVOvaW3JW6V+m7TuMGk/+Mu3JfnMq5safP+ub7VFdXdcLyPgiufqMn79Icx1rlwc/ZznT3sVO4AbBKDvKIYMHiM+AoByXXNf476LHvkBnHJSp9Ro3HPXcRcAeNtHojkhEptW3O/NCa0BdGMDpSp695GoYQAP4HK+ivzgmXNDNScbMoRp8S7BPBpq2s9wO7ce3pCiN+z+CpX0sTX3mQ0XLEsVBgm3moIsvC6tYf18qhQAvTq1VtP4j1JcjyynJg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c6ee66f8-722b-4a6b-581d-08d6466a6b84 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2018 17:40:21.1443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1955 X-OriginatorOrg: microchip.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181109_124037_608249_7F4B24D2 X-CRM114-Status: GOOD ( 12.10 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.4.2 on merlin.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [68.232.153.233 listed in list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, cyrille.pitchen@wedev4u.fr Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org gcc 7 with -Wimplicit-fallthrough raises: drivers/mtd/spi-nor/spi-nor.c: In function ‘set_4byte’: drivers/mtd/spi-nor/spi-nor.c:289:13: warning: this statement may fall through [-Wimplicit-fallthrough=] need_wren = true; ~~~~~~~~~~^~~~~~ drivers/mtd/spi-nor/spi-nor.c:290:2: note: here case SNOR_MFR_MACRONIX: ^~~~ Quiet the warning by marking the expected switch fall through. Signed-off-by: Tudor Ambarus --- drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 9407ca5f9443..8065d5d76be5 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -287,6 +287,7 @@ static inline int set_4byte(struct spi_nor *nor, const struct flash_info *info, case SNOR_MFR_MICRON: /* Some Micron need WREN command; all will accept it */ need_wren = true; + /* fall through */ case SNOR_MFR_MACRONIX: case SNOR_MFR_WINBOND: if (need_wren)