From patchwork Thu Oct 25 16:32:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: IKEGAMI Tokunori X-Patchwork-Id: 989212 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=allied-telesis.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DL4brCBl"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42gt4c0zjBz9sB5 for ; Fri, 26 Oct 2018 03:34:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Kb5locRWKxgEg9jJFP5vwg2JYcJpaBJmDrouKABE6is=; b=DL4brCBlLp5WkbpJQcnX3JEP46 ZVHURYx1XZPKCY9/V1QuRFwAsjiMzCkkojknup2FgN5f/C7Z37UqbcAFoTmZG7YqVEyYHYaEYF1Nz BaDX/cHN82zxlVfXkGYXPTprjASYiTK1tuhM1LFelkS4aSytzTvsh401Iuv9MsXUvqLjDmKB9vj7F hm+wDpPmugJu5Q4DGTIE5gRqlh38MvjplvcWN51jEvmytyxU5mwX+x6B7umaKLzgBukMwdEhTMHv6 tlKTrqraBrj5MIzbRB5SdSMNgbWrnua4hS6vMAhBueXe8BG0yT6TbEU7nx7mPvE4BlOKWFjGh7nA5 +/Es+DAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFiaI-0005GP-6k; Thu, 25 Oct 2018 16:34:10 +0000 Received: from mail1.bemta23.messagelabs.com ([67.219.246.3]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFiZ3-0004jJ-Bl for linux-mtd@lists.infradead.org; Thu, 25 Oct 2018 16:32:55 +0000 Received: from [67.219.246.100] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-3.bemta.az-b.us-east-1.aws.symcld.net id 11/7B-08438-720F1DB5; Thu, 25 Oct 2018 16:32:39 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLLMWRWlGSWpSXmKPExsUyLfyHiK76h4v RBvOmqljsblrG7sDosXlJfQBjFGtmXlJ+RQJrxrqWE+wFB7kqJl38wdzA+Ieji5GLQ0hgLqPE 4Z0bWCCcX4wSN5ccZ+pi5ORgEzCVmP5qISOILSKgJrG1/xwjSBGzwH1GibNr34EVCQtESXz4d RXMZhFQldh7ZC47iM0r4Chx9sF3VhBbQkBe4uHxdrBBnAJOEh3/nzCD2EJANX97W6BsTYnnPd 8ZIeqDJZ4+ucU4gZF3ASPDKkazpKLM9IyS3MTMHF1DAwNdQ0MjXSNdQ2MzvcQq3SS90mLd1MT iEl1DvcTyYr3iytzknBS9vNSSTYzAYEkpYOrYwbi0K/0QoyQHk5Iob2LKxWghvqT8lMqMxOKM +KLSnNTiQ4wyHBxKEry874FygkWp6akVaZk5wLCFSUtw8CiJ8M5/B5TmLS5IzC3OTIdInWJUl BLnvQKSEABJZJTmwbXBYuUSo6yUMC8jAwODEE9BalFuZgmq/CtGcQ5GJWFeBZDtPJl5JXDTXw EtZgJaPEPhAsjikkSElFQDo8xdpVj2FRnxyg9X7Ll/RuN5s/3Ez1Z7F3391t5zZPdNQybLgK/ 6f4UW/+X+bxWrxPzoTa/bxRfM3dY9uy9+P5Yr1n/1q0+5P4PUTBZGv2rd1KnFsTtrZr77Nm25 77oz1wKsHSK3Tnj9okjnTIG/J79aU7Hrh/3LzjvU5pou6CoTWfox42v4CSWW4oxEQy3mouJEA CiSaJ+QAgAA X-Env-Sender: ikegami@allied-telesis.co.jp X-Msg-Ref: server-26.tower-384.messagelabs.com!1540485156!931210!3 X-Originating-IP: [150.87.248.20] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.14.24; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4959 invoked from network); 25 Oct 2018 16:32:39 -0000 Received: from abricot-inet.allied-telesis.co.jp (HELO TKY-DS01.at.lc) (150.87.248.20) by server-26.tower-384.messagelabs.com with SMTP; 25 Oct 2018 16:32:39 -0000 Received: from swim-manx.rd.allied-telesis.co.jp ([150.87.21.50]) by TKY-DS01.at.lc with Microsoft SMTPSVC(8.0.9200.16384); Fri, 26 Oct 2018 01:32:36 +0900 Received: from ikegami-pc.rd.allied-telesis.co.jp by swim-manx.rd.allied-telesis.co.jp (AlliedTelesis SMTPRS 1.3 pl 1 ++E6B86F8C687C6288D9B5559052954DC9) with ESMTP id ; Fri, 26 Oct 2018 01:32:36 +0900 From: Tokunori Ikegami To: boris.brezillon@free-electrons.com Subject: [PATCH v3 02/11] mtd: cfi_cmdset_0002: Remove chip_ready() from do_write_buffer() Date: Fri, 26 Oct 2018 01:32:10 +0900 Message-Id: <20181025163219.25788-3-ikegami@allied-telesis.co.jp> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181025163219.25788-1-ikegami@allied-telesis.co.jp> References: <20181025163219.25788-1-ikegami@allied-telesis.co.jp> X-OriginalArrivalTime: 25 Oct 2018 16:32:36.0346 (UTC) FILETIME=[568075A0:01D46C80] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181025_093253_484971_5A57AC27 X-CRM114-Status: GOOD ( 10.86 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [67.219.246.3 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [67.219.246.3 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tokunori Ikegami , Joakim Tjernlund , Chris Packham , linux-mtd@lists.infradead.org, Fabio Bettoni MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org It is enough to use chip_good() only so chip_ready() is not necessary. For this change the order to check timeout is also needed to chagne. Signed-off-by: Tokunori Ikegami Cc: Fabio Bettoni Co: Hauke Mehrtens Co: Koen Vandeputte Cc: Chris Packham Cc: Joakim Tjernlund Cc: Boris Brezillon Cc: linux-mtd@lists.infradead.org --- Changes since v2: - None. Changes since v1: - None. drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 251c9e1675bd..c2e51768a02c 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1882,14 +1882,14 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, continue; } - if (time_after(jiffies, timeo) && !chip_ready(map, adr)) - break; - if (chip_good(map, adr, datum)) { xip_enable(map, chip, adr); goto op_done; } + if (time_after(jiffies, timeo)) + break; + /* Latency issues. Drop the lock, wait a while and retry */ UDELAY(map, chip, adr, 1); }