| Message ID | 20180705094522.12138-6-boris.brezillon@bootlin.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: rawnand: Improve compile-test coverage | expand |
On Thu, 5 Jul 2018 11:45:00 +0200 Boris Brezillon <boris.brezillon@bootlin.com> wrote: > It just makes NAND maintainers' life easier by allowing them to > compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX > enabled. > > We also need to add a dependency on HAS_IOMEM to make sure the driver > compiles correctly. > > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > drivers/mtd/nand/raw/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index c6764992cdfc..033900c0c618 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -119,7 +119,8 @@ config MTD_NAND_AU1550 > > config MTD_NAND_S3C2410 > tristate "NAND Flash support for Samsung S3C SoCs" > - depends on ARCH_S3C24XX || ARCH_S3C64XX > + depends on ARCH_S3C24XX || ARCH_S3C64XX || COMPILE_TEST > + depends on HAS_IOMEM Looks like ia64 does not define {read,write}s{b,w,l}() IO accessors. I'll just add a 'depends on !IA64' on both s3c2410 and orion to address that. > help > This enables the NAND flash controller on the S3C24xx and S3C64xx > SoCs
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index c6764992cdfc..033900c0c618 100644 --- a/drivers/mtd/nand/raw/Kconfig +++ b/drivers/mtd/nand/raw/Kconfig @@ -119,7 +119,8 @@ config MTD_NAND_AU1550 config MTD_NAND_S3C2410 tristate "NAND Flash support for Samsung S3C SoCs" - depends on ARCH_S3C24XX || ARCH_S3C64XX + depends on ARCH_S3C24XX || ARCH_S3C64XX || COMPILE_TEST + depends on HAS_IOMEM help This enables the NAND flash controller on the S3C24xx and S3C64xx SoCs
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- drivers/mtd/nand/raw/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)