diff mbox series

[v2] mtd: spi-nor: Add Winbond w25q128jv support

Message ID 20180625111748.5108-1-robimarko@gmail.com
State Accepted
Headers show
Series [v2] mtd: spi-nor: Add Winbond w25q128jv support | expand

Commit Message

Robert Marko June 25, 2018, 11:17 a.m. UTC
Datasheet:
http://www.winbond.com/resource-files/w25q128jv%20revf%2003272018%20plus.pdf

Testing done on Mikrotik Routerboard  wAP R board.
It does not support Dual or Quad modes.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---

Changes in v2:
	- Correct the title
---
 drivers/mtd/spi-nor/spi-nor.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Tudor Ambarus Nov. 20, 2018, 3:27 p.m. UTC | #1
On 06/25/2018 02:17 PM, Robert Marko wrote:
> Datasheet:
> http://www.winbond.com/resource-files/w25q128jv%20revf%2003272018%20plus.pdf
> 
> Testing done on Mikrotik Routerboard  wAP R board.
> It does not support Dual or Quad modes.

But you have dual and quad read support.

> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Apart of the observation above:

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
> 
> Changes in v2:
> 	- Correct the title
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d9c368c44194..3501dddc3167 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1239,6 +1239,11 @@ static const struct flash_info spi_nor_ids[] = {
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>  	},
> +	{
> +		"w25q128jv", INFO(0xef7018, 0, 64 * 1024, 256,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},
>  	{ "w25q80", INFO(0xef5014, 0, 64 * 1024,  16, SECT_4K) },
>  	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
>  	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
>
Robert Marko Nov. 20, 2018, 3:29 p.m. UTC | #2
On Tue, 20 Nov 2018 at 16:28, <Tudor.Ambarus@microchip.com> wrote:
>
>
>
> On 06/25/2018 02:17 PM, Robert Marko wrote:
> > Datasheet:
> > http://www.winbond.com/resource-files/w25q128jv%20revf%2003272018%20plus.pdf
> >
> > Testing done on Mikrotik Routerboard  wAP R board.
> > It does not support Dual or Quad modes.
>
> But you have dual and quad read support.

Yes, I did not express myself clearly there.
Flash has support for both Dual and Quad modes, but the board it was
tested on does not.
>
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> Apart of the observation above:
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> > ---
> >
> > Changes in v2:
> >       - Correct the title
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index d9c368c44194..3501dddc3167 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -1239,6 +1239,11 @@ static const struct flash_info spi_nor_ids[] = {
> >                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> >                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> >       },
> > +     {
> > +             "w25q128jv", INFO(0xef7018, 0, 64 * 1024, 256,
> > +                     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                     SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> > +     },
> >       { "w25q80", INFO(0xef5014, 0, 64 * 1024,  16, SECT_4K) },
> >       { "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
> >       { "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
> >
Boris Brezillon Nov. 21, 2018, 7:57 a.m. UTC | #3
On Mon, 2018-06-25 at 11:17:48 UTC, Robert Marko wrote:
> Datasheet:
> http://www.winbond.com/resource-files/w25q128jv%20revf%2003272018%20plus.pdf
> 
> Testing done on Mikrotik Routerboard  wAP R board.
> It does not support Dual or Quad modes.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.

Boris
diff mbox series

Patch

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d9c368c44194..3501dddc3167 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1239,6 +1239,11 @@  static const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		"w25q128jv", INFO(0xef7018, 0, 64 * 1024, 256,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{ "w25q80", INFO(0xef5014, 0, 64 * 1024,  16, SECT_4K) },
 	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
 	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },