From patchwork Thu Apr 26 15:41:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Lefebvre X-Patchwork-Id: 905163 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=essensium.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o2ff9j8p"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=essensium-com.20150623.gappssmtp.com header.i=@essensium-com.20150623.gappssmtp.com header.b="QIGRQOCl"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40X1fq4prvz9s06 for ; Fri, 27 Apr 2018 01:47:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=FlCdgahE9dKhL8KLU/9KW0twXCvqJgpNnk6PHpynzb8=; b=o2ff9j8p/fPQrSaRJOxTgYFdLM R9LqYw40COfkwS+nKMm3Ka2LJhTO63eBVgbHbrESZq+LuRXamL82PJnox07UhloyRtxa4ArHyvjcF QfV3w0cqXcjmJa0zyvft1AnJGjlPafT9w7UyrDfxvv/ZCFZ/jKSc0kce7Gov6ncatL0fOgMeGJJfQ y2hO6dPs9NpQRtC6CJ0ddYBFRJ3sqB6zOsFzYvKfanGV17PLWqHEJlpS3ws0zZ4ypQ+c6XQ680cYj cZeVH9lkQDRl1Jo5qEziFNxyZJaLaU1988KfRKN1VhIs5XRkJYOgTycSU5UcJJ8CbaaUpVsxUrXOb hRsWMETQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBj7H-0000bW-ES; Thu, 26 Apr 2018 15:47:27 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBj2D-0005hb-Ah for linux-mtd@lists.infradead.org; Thu, 26 Apr 2018 15:42:15 +0000 Received: by mail-wr0-x242.google.com with SMTP id d1-v6so57227904wrj.13 for ; Thu, 26 Apr 2018 08:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=essensium-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SGekFQ02Jb2f1MGEXDmz7SUTlE2cwAAgljJr2WU7fT4=; b=QIGRQOCl37GGNrMjjF5mQeiQUrASqFJ2ZAiQBgYbrZ+kwZ70os66Uq73cjxlnczItN bZdwnPY5FZ1dIogbb+hDfMC5Us+EoIHNmiUiYPODuF8bJVWyID30p96hdkdOirEtMlff 0+KvSRUaZ35Q0sSkwNuNtC51iJ949Y5r+8rSgPC7mlwsilpXSXj+VhWjwAPcqWTBHoWZ 5HXfCG42xXdUlMprZKUDwMQKnFBpaQoCUumrFSq7BSEK3XgeLAT2ndtPf+5XDzteDQDL IhRGPzxBw0vsH49ol1WITsOPC5NQ5uLZYXVIWaje4u6Metf6c7lK7FtEhZ6kwV/1LwlI dgSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SGekFQ02Jb2f1MGEXDmz7SUTlE2cwAAgljJr2WU7fT4=; b=kwjlP4Ay3U0ePw8KBDG+Dk3DRK21OQNP/lHPT/+8AkxSzrxoPixXPiwnXK1LbE/ju2 RyrlmpkgmY+Z63JW+xW1ulymcNmj6vdP/aFaMjIsfhcbdcq8k3Jxk0Or2G1jgfAsGeYQ aTNFI2xW82CBjXyTowgUzqOhZlRwZEJsJyG1AK8EFkNyk3pTO95CkN5iaKklL0L1ZN0L xx6WDiAz/GhcrUHNjjQ4d9E+lVE1IsUnoDXiZDc/OjOeqF9zmCtqUIn/8b6rQ/sKSKvp Vz2W8wGM87BEEuwMHLtqk8p1JAfiXwYn5ZXpYdXYiH74jc/3fQyE/2uZ23xMlBo+IO7x P4Ug== X-Gm-Message-State: ALQs6tD7yo0HEi1CA4YkbT9QK64uD+Mca1Qg5lmFcYQxQi4yP2VHSyyS WJ6S0znCW6Ir7vTdwn7UtW7paBSY X-Google-Smtp-Source: AB8JxZo9v21Rlga0HvdXYZPfPJLnM/plQrM0bytnVr7k8WlcKiKfgmxaVyiwRH/GA9QXl/QenS2bsA== X-Received: by 2002:adf:d0cb:: with SMTP id z11-v6mr9888123wrh.281.1524757321203; Thu, 26 Apr 2018 08:42:01 -0700 (PDT) Received: from Darth.local.ess-mail.com (178-118-196-9.access.telenet.be. [178.118.196.9]) by smtp.gmail.com with ESMTPSA id n23-v6sm19916031wra.39.2018.04.26.08.41.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 08:42:00 -0700 (PDT) From: Sam Lefebvre To: linux-mtd@lists.infradead.org Subject: [PATCH 05/13] mtd: nand: gpmi: return valid value from bch_set_geometry() Date: Thu, 26 Apr 2018 17:41:26 +0200 Message-Id: <20180426154134.8270-6-sam.lefebvre@essensium.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180426154134.8270-1-sam.lefebvre@essensium.com> References: <20180426154134.8270-1-sam.lefebvre@essensium.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180426_084213_436239_F7205874 X-CRM114-Status: GOOD ( 14.51 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c0c:0:0:0:242 listed in] [list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnout Vandecapelle , Sascha Hauer , Sam Lefebvre , Dries Staelens MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Sascha Hauer The caller of bch_set_geometry() expects the return value to be an error code, so !0 is not valid. return the error from the just called function instead. Signed-off-by: Sascha Hauer Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- v2: rebased --- drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c index 39834bedf460..83697b8df871 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c @@ -258,8 +258,9 @@ int bch_set_geometry(struct gpmi_nand_data *this) unsigned int gf_len; int ret; - if (common_nfc_set_geometry(this)) - return !0; + ret = common_nfc_set_geometry(this); + if (ret) + return ret; block_count = bch_geo->ecc_chunk_count - 1; block_size = bch_geo->ecc_chunk_size;