From patchwork Thu Apr 26 15:41:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Lefebvre X-Patchwork-Id: 905165 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=essensium.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KWLQvhVJ"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=essensium-com.20150623.gappssmtp.com header.i=@essensium-com.20150623.gappssmtp.com header.b="oe8+R5vi"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40X1hh2fNLz9s06 for ; Fri, 27 Apr 2018 01:49:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Ci5+StavQwH67SIH9QA1g96ibHL8XQGTeViV1iXOFmE=; b=KWLQvhVJCg5cI0W30aurVnWNY2 IOPbwFALbPXm0AaTaMZ9r4dsq3W0xygBY9W/e4FTdzQwbK4vSqVCIXAanCyQvNUUuggnTz82A4ioj c7k0QRYwhH9J8YqByjUneosXcT14BIIbaT9nBLTZ7N5kM43FSqDHTQ+mtST6B5sH+bxpSG1k7tp9g IvjmrHHU35bd7Q/xlKW+41eHmtzfa1Oyzw+vuMRuvDbaHJEpm8rSRZhtD9fFdOfVYs1kg4D0qwRKs Dd00TUDqzXYBtwAeh3COICSrKIdhO0ivWoG/VIDCsPKcYl5G49ID612a/YVJxrkq0kybPClssvgzn zPa61+ew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBj90-0001XW-6m; Thu, 26 Apr 2018 15:49:14 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBj2J-0005id-S5 for linux-mtd@lists.infradead.org; Thu, 26 Apr 2018 15:42:22 +0000 Received: by mail-wm0-x242.google.com with SMTP id b21so14198961wme.4 for ; Thu, 26 Apr 2018 08:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=essensium-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Tv3Q1N8V9H48VjWdaRLo8hkN2Sw8mSYqhRW4l7Y8pqA=; b=oe8+R5viG4OGX5vmJML95/vpRV6u/5LwO1aiw/6b3ixaS6bMG1Z/qUVaP4g3mnE8XO HENCZZ2rw38mvWaVzgtCD2WkQW4mLY3L1oWbxfuJQEG8PII138fgaRCbcYAQEGKjhiMs it3PKOIR+w+JDPQbJxzRNjKSm5x84FhEz1c+Rz4w7Q6nlNTmThbEglUqOv9gsynCqGoG z3ZWMCNNvuoWubQm2irXT71qbjtd0YHWNBSzHhgxGqap0Tb8mQ5ptDRMqYDmXXdUsgqi 5lJN7PJDtGetGAjtWEWJqyEg/87vZ8BUmk7XHLwTDaJnzqZp08xBPeoN0BxZiwNr7fXA fcwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Tv3Q1N8V9H48VjWdaRLo8hkN2Sw8mSYqhRW4l7Y8pqA=; b=Y5TJjJWaRQL0cs/QQyqgI7Nbz4hn0xCcNumhv+gU+4qOyfmcvQedNJmMV9NKuUnABP 5MBIHkTi5suEcL97BlEo9BG4c7F3dPIzz7cuHReoh3SKwMeBDo/MmnKVhIMTRKbaMEYg jmb1H5F15MIIIJ3Y3j76yZzey6eEZzixg1HaA0gw8yDV9MPitsU23Et9wS8yoSqcl6pK 2Qdjd4hFo+PdxiRtr3Bj9iLD2ur0J3Rof+ImywFmqNDbveYT+QAfl+xfM9AcAKX8GIoP UKZm7SkwDXoYiYPKMJ8t20EZWx9wY0op5LuPVkMIE+l10dmnd3wn5odQaRZ4bZ0JjrQ0 gxaw== X-Gm-Message-State: ALQs6tC107OdcUyfd7WbA6lSv+/fs8THHoJ1gnN/mCt2surw1eDakQyH pwXwSLs9RGmS0ijPyn7g0KxN9kGL X-Google-Smtp-Source: AB8JxZpMM/2d3DnzPvkf3fhH5RCaWdE5BZkXhoT2nWDDOjTt7cL6PUBWOfBY+TThqVVdT2qcWzSUrg== X-Received: by 10.28.113.28 with SMTP id m28mr6092337wmc.92.1524757327695; Thu, 26 Apr 2018 08:42:07 -0700 (PDT) Received: from Darth.local.ess-mail.com (178-118-196-9.access.telenet.be. [178.118.196.9]) by smtp.gmail.com with ESMTPSA id n23-v6sm19916031wra.39.2018.04.26.08.42.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 08:42:06 -0700 (PDT) From: Sam Lefebvre To: linux-mtd@lists.infradead.org Subject: [PATCH 09/13] mtd: rawnand: gpmi: poll the BCH interrupt bit in start_dma_with_bch_irq() Date: Thu, 26 Apr 2018 17:41:30 +0200 Message-Id: <20180426154134.8270-10-sam.lefebvre@essensium.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180426154134.8270-1-sam.lefebvre@essensium.com> References: <20180426154134.8270-1-sam.lefebvre@essensium.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180426_084219_932709_AEFCBBF4 X-CRM114-Status: GOOD ( 13.58 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c09:0:0:0:242 listed in] [list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnout Vandecapelle , Sam Lefebvre , Dries Staelens MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org To improve nand performance, the BCH interrupt bit must be polled before waiting for occurence. This avoids an unnecessary context switch. Signed-off-by: Sam Lefebvre --- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c index 60bc1bac7741..28a2cf106ddc 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c @@ -503,18 +503,31 @@ int start_dma_without_bch_irq(struct gpmi_nand_data *this, * Actually, we must wait for two interrupts : * [1] firstly the DMA interrupt and * [2] secondly the BCH interrupt. + * To improve performance, we first poll for the BCH + * interrupt. */ int start_dma_with_bch_irq(struct gpmi_nand_data *this, struct dma_async_tx_descriptor *desc) { struct completion *bch_c = &this->bch_done; + struct resources *r = &this->resources; unsigned long timeout; - /* Prepare to receive an interrupt from the BCH block. */ - init_completion(bch_c); + /* Disable interrupt */ + writel(BM_BCH_CTRL_COMPLETE_IRQ_EN, r->bch_regs + HW_BCH_CTRL_CLR); /* start the DMA */ start_dma_without_bch_irq(this, desc); + if (readl(r->bch_regs + HW_BCH_CTRL) & BM_BCH_CTRL_COMPLETE_IRQ) { + writel(BM_BCH_CTRL_COMPLETE_IRQ, r->bch_regs + HW_BCH_CTRL_CLR); + return 0; + } + + /* Prepare to receive an interrupt from the BCH block. */ + init_completion(bch_c); + + /* Re-enable interrupt */ + writel(BM_BCH_CTRL_COMPLETE_IRQ_EN, r->bch_regs + HW_BCH_CTRL_SET); /* Wait for the interrupt from the BCH block. */ timeout = wait_for_completion_timeout(bch_c, msecs_to_jiffies(1000));