| Message ID | 20171207093358.32234-1-miquel.raynal@free-electrons.com |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | [v2] mtd: nand: samsung: add ECC requirements for K9F4G08U0D | expand |
On Thu, 7 Dec 2017 10:33:58 +0100 Miquel Raynal <miquel.raynal@free-electrons.com> wrote: > Samsung NAND chip K9F4G08U0D minimum ECC strength requirement is 1 bit > per 512 bytes. As the chip is not ONFI nor JEDEC and because of the lack > of these values, boards using it fail to probe the NAND controller > driver. Fix this by setting up the default values. > > Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> Applied. Thanks, Boris > --- > > Changes since v1: > - Added the chip reference in the commit title > - Removed unnecessary checks. > > drivers/mtd/nand/nand_samsung.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mtd/nand/nand_samsung.c b/drivers/mtd/nand/nand_samsung.c > index d348f0129ae7..f6b0a63a068c 100644 > --- a/drivers/mtd/nand/nand_samsung.c > +++ b/drivers/mtd/nand/nand_samsung.c > @@ -91,6 +91,12 @@ static void samsung_nand_decode_id(struct nand_chip *chip) > } > } else { > nand_decode_ext_id(chip); > + > + /* Datasheet values for SLC Samsung K9F4G08U0D-S[I|C]B0(T00) */ > + if (nand_is_slc(chip) && chip->id.data[1] == 0xDC) { > + chip->ecc_step_ds = 512; > + chip->ecc_strength_ds = 1; > + } > } > } >
diff --git a/drivers/mtd/nand/nand_samsung.c b/drivers/mtd/nand/nand_samsung.c index d348f0129ae7..f6b0a63a068c 100644 --- a/drivers/mtd/nand/nand_samsung.c +++ b/drivers/mtd/nand/nand_samsung.c @@ -91,6 +91,12 @@ static void samsung_nand_decode_id(struct nand_chip *chip) } } else { nand_decode_ext_id(chip); + + /* Datasheet values for SLC Samsung K9F4G08U0D-S[I|C]B0(T00) */ + if (nand_is_slc(chip) && chip->id.data[1] == 0xDC) { + chip->ecc_step_ds = 512; + chip->ecc_strength_ds = 1; + } } }
Samsung NAND chip K9F4G08U0D minimum ECC strength requirement is 1 bit per 512 bytes. As the chip is not ONFI nor JEDEC and because of the lack of these values, boards using it fail to probe the NAND controller driver. Fix this by setting up the default values. Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> --- Changes since v1: - Added the chip reference in the commit title - Removed unnecessary checks. drivers/mtd/nand/nand_samsung.c | 6 ++++++ 1 file changed, 6 insertions(+)