From patchwork Mon Sep 22 18:49:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 392110 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CC1BF1400E7 for ; Tue, 23 Sep 2014 04:50:54 +1000 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XW8g3-0006pI-40; Mon, 22 Sep 2014 18:49:35 +0000 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XW8g1-0006mo-6l for linux-mtd@lists.infradead.org; Mon, 22 Sep 2014 18:49:33 +0000 Received: by mail-pd0-f174.google.com with SMTP id g10so4434041pdj.5 for ; Mon, 22 Sep 2014 11:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=vMGVXekqUuWMJml13d+xSKk1Tw018JhXHOCtQ4BmW7Q=; b=eaOjTQYdHAXUtEknZuQCc1pAEjpA2W1TCUdOuMcIZCa/VgAygPS6fHjGIyf6XhDX9f lUhwwwby3Cm13prYrftKJISR2KPq5Jx7TT9Y+T643AWmL4G11SWXj59Tf0NR/KMN3Jk7 VmBcFaUv+r/2K41JLN2onZqjbR3v/+vP4EgzNPWVBgxmzEiygSJGaEK8K81Cg7B/ZW+B DCw1MzAfgRNsJYbuLzlyug2/lLgz6VRuO423jozHf8zSn3V7zVReq0EkneAGG52APGB9 NKZ4WNFoor46U+RkDwyHaDHaPtmN1M6UpneDwt8oVpzM0f7w+fYv81pVkdGOsWwCNzNS LFkw== X-Received: by 10.68.162.3 with SMTP id xw3mr6825442pbb.142.1411411752418; Mon, 22 Sep 2014 11:49:12 -0700 (PDT) Received: from ld-irv-0074 (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPSA id sb2sm4594638pbc.24.2014.09.22.11.49.11 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 22 Sep 2014 11:49:11 -0700 (PDT) Date: Mon, 22 Sep 2014 11:49:09 -0700 From: Brian Norris To: Ezequiel Garcia Subject: Re: [PATCH v4 4/5] mtd: nand: Rename OMAP NAND driver Message-ID: <20140922184909.GS1193@ld-irv-0074> References: <1411231996-6387-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1411231996-6387-5-git-send-email-ezequiel@vanguardiasur.com.ar> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1411231996-6387-5-git-send-email-ezequiel@vanguardiasur.com.ar> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140922_114933_268085_6E8FDD54 X-CRM114-Status: GOOD ( 14.14 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c02:0:0:0:22e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, Roger Quadros X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Sat, Sep 20, 2014 at 05:53:15PM +0100, Ezequiel Garcia wrote: > Rename it to a less generic name, so the module is built with a meaningful > name instead of the previous 'omap2.ko'. You mention renaming only so that you can change the module name, but you also (partly at my prompting) argued for future merging of omap_nand and omap_elm into a single module. So it seems like you might have to do several renamings, in that case, right? omap2.c => omap_nand.c (this patch) omap_nand.c => .c (later) ...so you can link somethingelse.o and omap_elm.o into omap_nand.{o,ko} If I'm right here, then maybe (rather than multiple renames), you just want this patch for now? (untested) > Acked-by: Roger Quadros > Signed-off-by: Ezequiel Garcia > --- > drivers/mtd/nand/Makefile | 2 +- > drivers/mtd/nand/{omap2.c => omap2_nand.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename drivers/mtd/nand/{omap2.c => omap2_nand.c} (100%) [snip] Brian diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index b3237b742eb5..1a4d5e9db75b 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -26,7 +26,7 @@ obj-$(CONFIG_MTD_NAND_CS553X) += cs553x_nand.o obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o -obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o +obj-$(CONFIG_MTD_NAND_OMAP2) += omap_nand.o obj-$(CONFIG_MTD_NAND_OMAP_BCH) += omap_elm.o obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o @@ -52,3 +52,4 @@ obj-$(CONFIG_MTD_NAND_XWAY) += xway_nand.o obj-$(CONFIG_MTD_NAND_BCM47XXNFLASH) += bcm47xxnflash/ nand-objs := nand_base.o nand_bbt.o nand_timings.o +omap_nand-objs := omap2.o