From patchwork Tue Jun 29 08:32:37 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume LECERF X-Patchwork-Id: 57253 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 908FAB6F06 for ; Tue, 29 Jun 2010 18:28:51 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OTW9r-0004By-8E; Tue, 29 Jun 2010 08:27:07 +0000 Received: from smtp22.services.sfr.fr ([93.17.128.11]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OTW9k-0004Ac-90 for linux-mtd@lists.infradead.org; Tue, 29 Jun 2010 08:27:01 +0000 Received: from filter.sfr.fr (localhost [127.0.0.1]) by msfrf2222.sfr.fr (SMTP Server) with ESMTP id 5B4447000090; Tue, 29 Jun 2010 10:26:58 +0200 (CEST) Received: from dev.siriade.com (63.22.93-79.rev.gaoland.net [79.93.22.63]) by msfrf2222.sfr.fr (SMTP Server) with ESMTP id 42B7D7000082; Tue, 29 Jun 2010 10:26:58 +0200 (CEST) X-SFR-UUID: 20100629082658273.42B7D7000082@msfrf2222.sfr.fr Received: from localhost ([127.0.0.1] helo=dev.siriade.com) by dev.siriade.com with esmtp (Exim 4.72) (envelope-from ) id 1OTWFB-0002uL-22; Tue, 29 Jun 2010 10:32:37 +0200 Subject: [PATCH] mtd: cfi_probe: print manufacturer and id of probed chip To: linux-mtd@lists.infradead.org From: Guillaume LECERF Date: Tue, 29 Jun 2010 10:32:37 +0200 Message-ID: <20100629083204.11146.37097.stgit@dev.siriade.com> User-Agent: StGit/0.15 MIME-Version: 1.0 X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20100629_042700_460384_147CD26F X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.2 (+) X-Spam-Report: SpamAssassin version 3.3.1 on bombadil.infradead.org summary: Content analysis details: (1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is freemail (glecerf[at]gmail.com) 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, low trust [93.17.128.11 listed in list.dnswl.org] 1.2 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list 0.0 T_TO_NO_BRKTS_FREEMAIL T_TO_NO_BRKTS_FREEMAIL Cc: David Woodhouse , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org 2010/6/29 Artem Bityutskiy : > This is not a debugging print, so I think you should do it in a more > user-friendly way. E.g., "manufect. ID %#08x, chip id %#08x". OK, here it is again. Signed-off-by: Guillaume LECERF --- drivers/mtd/chips/cfi_probe.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c index b2acd32..8f5b96a 100644 --- a/drivers/mtd/chips/cfi_probe.c +++ b/drivers/mtd/chips/cfi_probe.c @@ -235,9 +235,9 @@ static int __xipram cfi_chip_setup(struct map_info *map, cfi_qry_mode_off(base, map, cfi); xip_allowed(base, map); - printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank\n", + printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank. Manufacturer ID %#08x Chip ID %#08x\n", map->name, cfi->interleave, cfi->device_type*8, base, - map->bankwidth*8); + map->bankwidth*8, cfi->mfr, cfi->id); return 1; }