From patchwork Mon May 31 14:03:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 54097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (unknown [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A7E59B7D6C for ; Tue, 1 Jun 2010 00:05:38 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1OJ5b0-0004LK-E0; Mon, 31 May 2010 14:04:02 +0000 Received: from ey-out-1920.google.com ([74.125.78.150]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1OJ5ax-0004Jo-S4 for linux-mtd@lists.infradead.org; Mon, 31 May 2010 14:04:00 +0000 Received: by ey-out-1920.google.com with SMTP id 13so145934eye.26 for ; Mon, 31 May 2010 07:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=RDOZIAmyeTt9cNjfHyN0UYK6XDI+IqRAWDP997i3ISo=; b=BafFF5LrJl/LvMy6sI4XQTUl3V8FzsYX2bAm4FyqCidpG7iP5wyaAgGfxZxxKCZWSF l6XWgohQQUkcj6CDezXRN5d7VW4BTQmUNxArAQeKKfESW18h/te0607Kzh0q9+43Kr4F scvDcL92bK5TrH4YjEzQuTUMUoBX1oESeQJ74= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=O2767leyMNx8/N7Pygv5BKK1y8Dc2fpl2OakSsUs2DnWzUM2b542dKsUKhdy0Lut22 yUyCbncRdEReGA6ffGJISlJlP2FSDpHCe8D6Cm+plKzumQXFcAXdqy/AoV9lliayXIjK VB15LvD9jekza3ifKPLLVT6kijyen8GC0rDJU= Received: by 10.213.5.6 with SMTP id 6mr2192225ebt.11.1275314637843; Mon, 31 May 2010 07:03:57 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id 16sm3079915ewy.7.2010.05.31.07.03.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 31 May 2010 07:03:57 -0700 (PDT) Date: Mon, 31 May 2010 16:03:38 +0200 From: Dan Carpenter To: David Woodhouse Subject: [patch] mtd: return success on blktrans_ioctl() Message-ID: <20100531140337.GV5483@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20100531_100400_003969_2011843C X-CRM114-Status: GOOD ( 12.59 ) X-Spam-Score: 4.0 (++++) X-Spam-Report: SpamAssassin version 3.3.1 on bombadil.infradead.org summary: Content analysis details: (4.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is freemail (error27[at]gmail.com) 2.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (error27[at]gmail.com) 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.78.150 listed in list.dnswl.org] 0.6 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [205.177.176.130 listed in dnsbl.sorbs.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Artem Bityutskiy , Maxim Levitsky , kernel-janitors@vger.kernel.org, H Hartley Sweeten , linux-mtd@lists.infradead.org, Ben Hutchings X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org There was a break missing so we returned -ENOTTY on success instead of zero. This was introduced by 048d8719956: "mtd: blktrans: Hotplug fixes" Signed-off-by: Dan Carpenter diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 03e19c1..a6bb586 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -245,6 +245,7 @@ static int blktrans_ioctl(struct block_device *bdev, fmode_t mode, switch (cmd) { case BLKFLSBUF: ret = dev->tr->flush ? dev->tr->flush(dev) : 0; + break; default: ret = -ENOTTY; }