diff mbox series

ubifs: Fix an error code in ubifs_jnl_write_inode()

Message ID 1622801514-38016-1-git-send-email-yang.lee@linux.alibaba.com
State Superseded
Headers show
Series ubifs: Fix an error code in ubifs_jnl_write_inode() | expand

Commit Message

Yang Li June 4, 2021, 10:11 a.m. UTC
When the code executes if (ui->xattr_cnt > ubifs_xattr_max_cnt(c)),
the value of err is 0. However, we can see from the ubifs_err log
that the value of err should be -EPERM.

Clean up smatch warning:
fs/ubifs/journal.c:886 ubifs_jnl_write_inode() warn: missing error code

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 9ca2d7326444 ("ubifs: Limit number of xattrs per inode")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
 fs/ubifs/journal.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index 2857e64..2307173 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -882,6 +882,7 @@  int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)
 		struct ubifs_dent_node *xent, *pxent = NULL;
 		if (ui->xattr_cnt > ubifs_xattr_max_cnt(c)) {
+			err = -EPERM;
 			ubifs_err(c, "Cannot delete inode, it has too much xattrs!");
 			goto out_release;