| Message ID | 1558379144-28283-1-git-send-email-kdasu.kdev@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | [v2,1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional | expand |
Hi Kamal, Kamal Dasu <kdasu.kdev@gmail.com> wrote on Mon, 20 May 2019 15:05:11 -0400: > nand-ecc-strength and nand-ecc-step-size can be made optional as > brcmnand driver can support using raw NAND layer detected values. > > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> > --- > Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > index bcda1df..29feaba 100644 > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > @@ -101,10 +101,10 @@ Required properties: > number (e.g., 0, 1, 2, etc.) > - #address-cells : see partition.txt > - #size-cells : see partition.txt > -- nand-ecc-strength : see nand.txt > -- nand-ecc-step-size : must be 512 or 1024. See nand.txt > > Optional properties: > +- nand-ecc-strength : see nand.txt > +- nand-ecc-step-size : must be 512 or 1024. See nand.txt > - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this > chip-select. See nand.txt > - brcm,nand-oob-sector-size : integer, to denote the spare area sector size Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
Hi Kamal, On 20.05.19 21:05, Kamal Dasu wrote: > nand-ecc-strength and nand-ecc-step-size can be made optional as > brcmnand driver can support using raw NAND layer detected values. > > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> > --- > Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > index bcda1df..29feaba 100644 > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > @@ -101,10 +101,10 @@ Required properties: > number (e.g., 0, 1, 2, etc.) > - #address-cells : see partition.txt > - #size-cells : see partition.txt > -- nand-ecc-strength : see nand.txt > -- nand-ecc-step-size : must be 512 or 1024. See nand.txt > > Optional properties: > +- nand-ecc-strength : see nand.txt > +- nand-ecc-step-size : must be 512 or 1024. See nand.txt > - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this > chip-select. See nand.txt > - brcm,nand-oob-sector-size : integer, to denote the spare area sector size I think you also need to change all references to nand.txt. This file was recently moved to nand-controller.yaml. Regards, Frieder
Schrempf Frieder <frieder.schrempf@kontron.de> wrote on Tue, 21 May 2019 09:31:04 +0000: > Hi Kamal, > > On 20.05.19 21:05, Kamal Dasu wrote: > > nand-ecc-strength and nand-ecc-step-size can be made optional as > > brcmnand driver can support using raw NAND layer detected values. > > > > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> > > --- > > Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > > index bcda1df..29feaba 100644 > > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > > @@ -101,10 +101,10 @@ Required properties: > > number (e.g., 0, 1, 2, etc.) > > - #address-cells : see partition.txt > > - #size-cells : see partition.txt > > -- nand-ecc-strength : see nand.txt > > -- nand-ecc-step-size : must be 512 or 1024. See nand.txt > > > > Optional properties: > > +- nand-ecc-strength : see nand.txt > > +- nand-ecc-step-size : must be 512 or 1024. See nand.txt > > - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this > > chip-select. See nand.txt > > - brcm,nand-oob-sector-size : integer, to denote the spare area sector size > > I think you also need to change all references to nand.txt. This file > was recently moved to nand-controller.yaml. > Oops, completely forgot about that *again*. Thanks for pointing it Frieder! Miquèl
diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt index bcda1df..29feaba 100644 --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt @@ -101,10 +101,10 @@ Required properties: number (e.g., 0, 1, 2, etc.) - #address-cells : see partition.txt - #size-cells : see partition.txt -- nand-ecc-strength : see nand.txt -- nand-ecc-step-size : must be 512 or 1024. See nand.txt Optional properties: +- nand-ecc-strength : see nand.txt +- nand-ecc-step-size : must be 512 or 1024. See nand.txt - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this chip-select. See nand.txt - brcm,nand-oob-sector-size : integer, to denote the spare area sector size
nand-ecc-strength and nand-ecc-step-size can be made optional as brcmnand driver can support using raw NAND layer detected values. Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> --- Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)