From patchwork Fri Jan 18 05:30:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 1027115 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eHZAkbWj"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nifty.com header.i=@nifty.com header.b="IqUYVyYC"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43gqLS5Pslz9sBZ for ; Fri, 18 Jan 2019 16:31:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=CD4zbWr2DIIEZmUtiv1VcAn0EjcWz/iMI1LoyXYb348=; b=eHZ AkbWjA+wXFZ1P/fn6NcExDEvxc9UEPoU4YrJ0cInL6hUMIdsBJKRicoFB8udhf2+dVx9GYMc6DWKg xezA4OU0tm4sAd4W0Cq+/xrnLfsdJU0CNsn3mBaBHqOPJHARNvWLuZuyIdHwPQrydCi2Fe7BBv3zi wVPr7BxcgiKcj94I/ZmOBaBwMaLcSxZzQ5uYSmPdpuP5TSd26VunppWIYkMaaqInT99ALtRmNuJxt h9nNcAcl59VzD9pSVAhO3u3ayP5vdQQO4JSd2krp1BWZ/d4HVvHgfT1CM3LIAzsw0xFcAbSDkZaMZ qwkecc+rp1hVT8ltIGRYVJxe3LjafDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkMkP-0001Ad-Ls; Fri, 18 Jan 2019 05:31:17 +0000 Received: from conuserg-12.nifty.com ([210.131.2.79]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkMkM-00018y-3L for linux-mtd@lists.infradead.org; Fri, 18 Jan 2019 05:31:16 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id x0I5Uo9J016515; Fri, 18 Jan 2019 14:30:51 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com x0I5Uo9J016515 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1547789451; bh=g0IEtR2LdGStw2ATPKCXJNsCFAJuQAUZId86SAXzF9Y=; h=From:To:Cc:Subject:Date:From; b=IqUYVyYCr2u20fWkbOsEFg9rWXO45lPD/7NZ5UyxX3zUB5d6Wr1rX3dhXZm9TsiaO 8jLl2EttACDLk+qZkF46YSf9gXnrGhgsNovK6ieRKHlNOJajkP8yNKuiKI4rPdcBc5 G1mLUyJkzyhTn5E+vKr/3+zDm6GRDR0NrN4wfaiAp5lNjIgp+yMl2ZKonhJDDT0Ram 18s1YQ8TZfLJonk5R1JZEgaZbU+H08gDnbziyr2mISmqQPaguirWfrLIq6RV9XLFqz uBTI0uXOrY5eGLUZaOBHvs9r7g+IIMQx2jrm4GNxuS9YQrnVJK6xvLgUYXkJQalSHh K2BHRUocjcj9w== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Boris Brezillon , Miquel Raynal Subject: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again Date: Fri, 18 Jan 2019 14:30:38 +0900 Message-Id: <1547789438-11899-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_213114_371868_FF3CB00F X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [210.131.2.79 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, "linux-stable # v4 . 20" , Masahiro Yamada , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops") missed to invert the if-conditonal for denali. Since then, the Denali NAND driver cannnot invoke setup_data_interface. Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops") Cc: linux-stable # v4.20 Signed-off-by: Masahiro Yamada Acked-by: Miquel Raynal --- drivers/mtd/nand/raw/denali.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index eebac35..6e8edc9 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -1322,7 +1322,7 @@ int denali_init(struct denali_nand_info *denali) } /* clk rate info is needed for setup_data_interface */ - if (denali->clk_rate && denali->clk_x_rate) + if (!denali->clk_rate || !denali->clk_x_rate) chip->options |= NAND_KEEP_TIMINGS; chip->legacy.dummy_controller.ops = &denali_controller_ops;