From patchwork Tue Jan 30 16:49:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 867555 X-Patchwork-Delegate: cyrille.pitchen@atmel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Er8p2Uv7"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="c2tgbkCQ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zWC7t5jxgz9ryv for ; Wed, 31 Jan 2018 03:51:22 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/3QaDO61ltXgYN+lezrJE5/ISDEup9F33XbbaU0+EpY=; b=Er8p2Uv7zeW93O wTik2C2n2iJXQjxzn+4tPnLdzfcWz3ON+GhPn3Zd71571Ai3esjV4r21dVw3rKrTSK/VkAhc+4kpe X+W7jBqAfJafr9w0bDA7WFey7taiJy2LJgHNQf/Zj/cJpT2ul6gum0IuU/ZfSw7y6X/npdniwHJMs +asDFd1mwBGeJHQykwHQxdl3lRZ9OTMTtUVGGcseREwMj2E9i6TGaHJTbJ+4TAo29ErvhU5OrsvlH p7FQQZ2ah0h+Ut2kY/oVY4/8WlC/PGEP45ngJOYxqLSJ3ICsYD4bOkzMamuJOfV33bVKYIXPKKf5s MH0Qf+cz7b1SeFbv8Ddw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1egZ7t-0007aZ-Pp; Tue, 30 Jan 2018 16:51:17 +0000 Received: from mail-he1eur01on0612.outbound.protection.outlook.com ([2a01:111:f400:fe1e::612] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1egZ7Y-00079w-G7 for linux-mtd@lists.infradead.org; Tue, 30 Jan 2018 16:50:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LpWY45B4Acz4HQ4aqNfBvs+GAIkQO/q8UW3tsCo/5lM=; b=c2tgbkCQwUlIbEiz3qlBxM79zjMlRPxawqkuY0niaEJ0W2ywgr6ggwl6oC9vRDE9mhdIGYbfzQZOqmUqY6YMZUQ+erl789xU9P0MnlAUSOhNEnfj1Ug6piOcI+6hwQsqVtJ2BptGF4Rh8ih5j6dM+1KT2nUFUMWGYfkzUJpyJhY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; Received: from idcbfarm.ap.freescale.net (192.88.169.1) by DB6PR0402MB2839.eurprd04.prod.outlook.com (2603:10a6:4:98::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Tue, 30 Jan 2018 16:50:35 +0000 From: Yogesh Gaur To: linux-mtd@lists.infradead.org Subject: [PATCH v5 2/2] mtd: fsl-quadspi: fix init AHB read in fsl_qspi_nor_setup() Date: Tue, 30 Jan 2018 22:19:30 +0530 Message-Id: <1517330970-15197-3-git-send-email-yogeshnarayan.gaur@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1517330970-15197-1-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1517330970-15197-1-git-send-email-yogeshnarayan.gaur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: BM1PR0101CA0044.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::30) To DB6PR0402MB2839.eurprd04.prod.outlook.com (2603:10a6:4:98::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 385f00e9-fcd9-402f-e626-08d5680196ab X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR0402MB2839; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2839; 3:3JSEk2n+hX6yH5U0cIfdyL2YjLppNrHFWlUNHKkpNFEwhE2msJz48B7LXznH2Y01CNtGAsaaYZ8raiqMOYJ0XAeyGxMAMhJpxmsCiIDs03k28HtOsH7bROjXGxZ0d5l2rYbeQa/KyBRZqdxPy4mjCl0A1OChuSUC/KOlbQGY+ueLu7xQL2CbZHMJm9lkmx4SfXS+oF/5KWkh51dcWNfHFQ5eZY56wH5OwZVOZZ0R780w19qonhD/S0gJAt9KfH6L; 25:lnBwE0UlqdRbgNaBpPbHY+D5okutzlGkrqEfyRwROK5LY7us9Grc4wfarG1rP/5awWVl2NDbYH2PpMJpHff6upheU6AXyg/qgAuNEhFYkmf0BzxUxd4+vPMkQITwW+rE5qpCsfcO4MxCdSKNYP2Z7L8+6WmaX/1+skaS35sMUA6cxSpk2yo35mZuSOWj6MA6P+4sissWXa+8oVyv9Ko4UODiZBZl/vblJZXV6qM+3NFrrB76mCTcZYHJjMQ/jGe70aByQxBW0MlDzucYc9se2StVV0qGBM2fyAYUDQIPtotrE4DjitYbnqZ9Kh+odtRScY71XOosRC7nwCBHHt1uVQ==; 31:uKUBM09NvslfcTta4ATSl3+kh//hXjyPe5OBE3/b4H2gWuHjVPybGRPcbP0Y4cRO6WDpcFMA1cBmAIeWGIGruxWUUNoYrumTEj41mPCUMd2yEV8FH3ufX6UBcYLPVadkvBOPqqY4vzwKYaTgZ1/BD+Yh7kDwn/Thl+l2qNxr9gYK6Ef6ilvoQNVl51sCq+iBs7YZPujGY/5aysRlgjpGKIlVojB2TH2RenxV4KKhhQY= X-MS-TrafficTypeDiagnostic: DB6PR0402MB2839: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2839; 20:Yhm5KKQfS2iUqupJaCC2tnDOVdevGN/ilDnJIUMc/wnQMG/D+13vedexbTWmwSTTrEpPuYW8+M1VD0ckmWA2817tSw0l6AA4JcfMRGyXg0cgHz3Xn4EiO8RKQFS2Jc5niMOty5im2MdERKkcf3OjHJriTXDgWTrgEivtSJRG3JBKPFQX7iUdSwS5hj7iUgcKM6eeegKH2uAV+9qUZPzDQ/A1OGQjs5kRW7V5pCGxcYVel4LIbYYvLYZOgMmviPD8WFGEwZRL0HRBCI1yQYZXLtEUW9FOyuvehCY3aiInLnpAdy4SScIoRsByuKsmGklGQOS1/tHKljvaD5B2QMlauuHOENTC1ZdjnfjCrb11HaAbu16VAzdHqD2KJOPqYvw+ndD4LyxQAf37PyPq5N1ImBrjhjy7xDfUwzSMdeUgCC2BpFJjIyCW4mfbGR6WY/+o9/b0P8bWxJPQvRXONhmB2HivWtcaBYtl2IyNcFg5KIYsAX2nCKowwJNTrzXBbFI4; 4:ZvQVoOdHxAuO1vtC0haFQ8EEfmI1keYTqOdeqvMQSzpslyyEdYCMYnLLjyxs1eqwlCASyS+gFqiqYUygtfmcNJt9lvmCSNxCaodqSgqSaHaf0tr9PpbSCwIDvLtuDDKpA+MTcsmaa1I52rOHxMWB6WtrUEbNgwK2xgTo4WUj2X+MKHQAIdV3QP18MuP2fHidMo+hhlRshL4d9J0TRkB59fJlgD8FVV2c0M57t7aMNzgBm2gIMQAxVAAi9X5ktNifOmP9+oqegh36tOcmiTUUS3q9E6Zubg//L5z2uwxKaVVJ6pDMqedji8I85b+8i+QoXvmD0W62EeC5LM5PtdeMO+rqt3+TmE3LrjMN94LDUhA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231101)(944501161)(6055026)(6041288)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:DB6PR0402MB2839; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0402MB2839; X-Forefront-PRVS: 0568F32D91 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(39380400002)(396003)(376002)(346002)(199004)(189003)(16586007)(36756003)(8676002)(97736004)(105586002)(186003)(16526019)(4326008)(39060400002)(6116002)(50466002)(6512007)(53936002)(3846002)(2351001)(81156014)(2361001)(86362001)(316002)(50226002)(8936002)(81166006)(66066001)(6486002)(386003)(6506007)(51416003)(6666003)(2950100002)(106356001)(305945005)(25786009)(52116002)(7736002)(76176011)(47776003)(48376002)(5660300001)(478600001)(2906002)(68736007)(6916009)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0402MB2839; H:idcbfarm.ap.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0402MB2839; 23:DE+DY/somn4rAaj4EnRpWq/MOTMybM4XE/YBCzZ?= Df3/CRqiaO0eyA39NymMsd+1YjyX1sHVwDMBNwGZ4Pd/BU6fVyHIH0f/zTtNaIODrlCHCokbA8gkivRRWRVUKAhcC+fewcTd/gF7vv8C1ysVTzxE+pxs1ddlRCF8Cvt8YoPDIpuzUqzlgy2Of8sghKZXcpuboIVAlsCMJTWvcOvtTBt2fDVVneURvh6ddtJ1I4+e0vSxqT9IGwxRJu9JixROIY7xK5c/ISX0kQQL51U9MKpvAZYDJkTZ9gIru1Y3HlhXkyRbmYMUjBB80PS2UuWqvz0dhG6GqSfkZ/mVIgOXdgtoSZ0AUZf+fg7iRWPrRWhXIlb6pY/P5jX2dqPBDPiE05LhmQKMsoe4k8ZFZ20KjvW5gBcc9xKfKyifVqokT0/MF/KZAG/hPn8yIhCCweg9ETDCe5LGvW4Mdjs/7LBf1TKK/YmbV33vY4G7CA/lbSsWNLf/drsiWlXsaHiM76bpAEZzSZ5N5mytZmI5H8JbK9iiVddjNClTPy0dgVRGW/I3tvKtt+kItFN9S0MeKcjjY/h9r3GHJ+KyiZ9/rtSH7Fx6vvntL4rZO347cbbH9Ohfl2OHLMaaSXz7+i4PlTnMQblPkVYPHPs+5YzIUB1dHqGiop2RGvP2AnH8uvdATiWC1PL57BpKUpx2DegSRve1WH7JLdNblqyEiVDcKukNmpyE9eF2CgJ4a8iBeL7WI98rplGiWk7vgTFChBG8ZO+vAF5LkGf6r+6bT44jUrabD7OIrYt4nyruIEg6CC7WLh1wNc0/IGdgMPqdBq+JYOJhw+PT0P9UUSoM4JvJu3JJfGROVC9Y82zEvcHAXpkejigUzkASlsvaYR8Y7f6jzZ4INsPSQkcRA+DnMqB6eBLu9pstS0emG5TVFVDowd/A8UpjDUBF8j/TYItDbZ59HJqrI/XNI3iXth6DuV0SQyKSoWGFYn7971WzMZHYzWgwrm5WG9MbqR52JnAUA+2eBQM+UQ5CYeYXj/E3x+26YgGNWI1TI6nOioJ2JIrTEmDhpkb7AV0RR6mKoXCqeQzgWaTCEf7pTwbm0GVS9yuyuDHB4zeoygi2g+DZPvimzayaF2QoI4e3vAtTCfNYSPbFgdBsd4jXY2XJj1edrP5PPFdKiig== X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2839; 6:ojmGqkamyJ64TwrAkSV7nwogFu1RwbZ5iTQP7HIsElOtpxQEkKmLWPSgrqvhQBmktmVVSRNexcxPrht8lXQ/V85uwQZ3sdIGW84JvQgeFkPRF5MKRQ5fIXNrUwtD4CFHMKwiVkxX5C1k5Ar+OxI1dQ8qWZlMjP7wFrbY7EYy4LqYPxijvYICTQvicbQzcuIRf6eEu413mN+ZGLD3coWhgTAU4/yGQMigbuNV1hCS4W06Jv4tWhLVPOjwlMvct9FXpNKAJKG8jPwbAtQRxziT/kn11TgphSd8xXIJt6qTItoDl+s6fPomfOKmoYSCH/paaKX4/0xh6LQLpLwJTKkMKwh8oTm3zRRKMQLEWQmTEVs=; 5:Xqibxtq+QxQfJX7omPZhKihypke9ZQ2Qg8NH4YyLGbWnLWhcitM/PC5WX8ESRmvM/W1oUPaiaLkDA1QMJ69PsMTHuk321ViZizpbg60k/lgPwMZE0kZ8itlQwEIVY61j/22pa3jxEaRI1fshrqe4lXBr++ECLhHYbdSJngqCSTc=; 24:tg5kciYHfiNBPV4lVw0Fik3bpNaNll7uucM1kJwi6mmM/6rG240nfRoMvakWNJXH/qv+uGO10PrslsLxTyFZrkHAQvlaqa1sVl7ugeyA7kY=; 7:UdREka/ZGvnyI+OKpwJ6nXxf7Gj4EnewRN8Q1o9SDcOheEKmsp/IegRVmHFvfVI7oQpknyTr20u8JmXwxgpvj/59J0KLouQDR1Q7zhbJq1B615JT4hxWO4ecopxdDsJOBN0K/XITNJPqD1hEQ7piOwm17HCJ8Hq++w+9VWB+Ubjyw0f3M+2gfMevFOuMHdZZB21+hVh+SFPDRuKcHJj8dWnEfWOyTFMT9iIvv4N31PSxvIm7GBwaw7VSg6jmvfgr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2018 16:50:35.6615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 385f00e9-fcd9-402f-e626-08d5680196ab X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2839 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a01:111:f400:fe1e:0:0:0:612 listed in] [list.dnswl.org] 0.0 T_SPF_PERMERROR SPF: test of record failed (permerror) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: boris.brezillon@free-electrons.com, Yogesh Gaur , prabhakar.kushwaha@nxp.com, suresh.gupta@nxp.com, cyrille.pitchen@wedev4u.fr, han.xu@nxp.com, computersforpeace@gmail.com, festevam@gmail.com Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Move AHB read initialize in fsl_qspi_nor_setup(). In file spi-nor.c, func spi_nor_scan() calls nor->read() thru spi_nor_read_sfdp() API. Presently, fsl_qspi_init_ahb_read() called from fsl_qspi_nor_setup_last(). Func fsl_qspi_probe() calls spi_nor_scan() first and then calls fsl_qspi_nor_setup_last(). When nor->read() being called from inside spi_nor_read_sfdp(), QSPI cntlr AHB mode initialization is not yet done results in data read error. Initialize AHB read inside fsl_qspi_nor_setup(). Signed-off-by: Yogesh Gaur --- Changes for v5: - None Changes for v4: - None Changes for v3: - None Changes for v2: - None drivers/mtd/spi-nor/fsl-quadspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index 84c341b..2b3b3eb 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -787,6 +787,9 @@ static int fsl_qspi_nor_setup(struct fsl_qspi *q) /* enable the interrupt */ qspi_writel(q, QUADSPI_RSER_TFIE, q->iobase + QUADSPI_RSER); + /* Init for AHB read */ + fsl_qspi_init_ahb_read(q); + return 0; } @@ -809,9 +812,6 @@ static int fsl_qspi_nor_setup_last(struct fsl_qspi *q) if (ret) return ret; - /* Init for AHB read */ - fsl_qspi_init_ahb_read(q); - return 0; }