From patchwork Tue Jul 18 00:54:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 789812 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received-SPF: None (mailfrom) identity=mailfrom; client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver= Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HE2aDUSE"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ps8tHWfw"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xBMBg2Nv3z9t2M for ; Tue, 18 Jul 2017 10:54:50 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=0TSb+w+5dqHS/cUbzcMnW1QvngzbSVT+L8KJH7ybmqc=; b=HE2 aDUSEze0wx0VvdR+AWGloAcc4OuRb7fMc6xj5WFfP0n7oV/Shwd6aJjE/Uq6XhzVXoe5DUQ9F7LYC i75Meyy/WMHEJLjxJF1+IKfeA5rNrZe62YMdUIqjWz8g6G0yLrHRwKa58UpqulmKXhqkspS27VB5F qUP/vPIPM1hVLqkUjxP0ozQP0WDKZuwrTe7DYo3I2aojmX78FyzLllF7L6GSFl7d1hERDqbKvxHrH yB9Pf4CANKJDZdBBDBq4jwIVShuUSkurg7miTW2iJDH0vXyKztgd1Dnqh7ZrsKkug03lcCFethBSe BQtnCllGCoCjER/vUY6PRmD2JWk0nUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dXGmf-0003nv-Ev; Tue, 18 Jul 2017 00:54:41 +0000 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dXGmb-0003mM-VE for linux-mtd@lists.infradead.org; Tue, 18 Jul 2017 00:54:39 +0000 Received: by mail-qk0-x241.google.com with SMTP id q66so778063qki.1 for ; Mon, 17 Jul 2017 17:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=A9/kWiLu1dZTMG+AOSsSWumlHvItizbzbYjBG1gH+XQ=; b=ps8tHWfwYrqPaOnGnHmlHAIj8Hr0HUXCV7qbhRU88KWltCV5nNAcPVG3sErOtNJU/m gNXIs0stJyEo+Aj+Pzw/Hkok9l4CgnJOKVlcWR8dNxsvrF+iYmalyIVJKoQvMXtoKjiD WhIZCs1g0Nh8IPPoCDLwy9OjXJyBIOrIXWRH+9SACFMaU9cSKNP/LSavpv2joBPZAkVV yMQD0NAv1Gmu6Vzi1V9bsbWuuK+uRUDRIhbcLp8p0ZQYn3rHcTVHJAxXqmLte1yIEPHm FzA1cN28OV48/0pYuVMxCaxlBfcagG6H7WXnWUxnnkwAhxKPPAGOJTzjHEjxii7wsTeF L6zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=A9/kWiLu1dZTMG+AOSsSWumlHvItizbzbYjBG1gH+XQ=; b=V4jJSxuoV1E8SByKkSyvvX7b+aZBv6z8wrxXkrAI3rte8z55fBnRc5gaxHVK9lIZXY PcL3KeflNNjLVMSgUuCLSRC7vdNTqnhEdpMgBbNEUza+LbCXQecR4MM0MPyfAwpcylMX jy9vECD+NN+riUX7GLWCnFFSWGzNuTMuPdcZEHhRLqdU90AkmSthotbXBWVWK63Xl/WB GtLBVCQiBOx64dHesyYd/9tkBRRKwY75iVVQe0FFsNWsPiiDS14ro1mRVtdr7gdkjgmR 8ZKM8PRRWpE+FwEDicFkn/xfXLT7HhdDBKkC9bEBK8YS1HeHfPCogy3aHu5vEcbYP5aJ LWsA== X-Gm-Message-State: AIVw112qID9Aer3w0AesTtE5o5hg+w/O1rwJkQZz83VRdGg83sv6mLYp ZyPTugoxcpdjhg== X-Received: by 10.55.104.148 with SMTP id d142mr278594qkc.182.1500339256534; Mon, 17 Jul 2017 17:54:16 -0700 (PDT) Received: from localhost.localdomain ([187.180.181.24]) by smtp.gmail.com with ESMTPSA id w19sm646531qtc.22.2017.07.17.17.54.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Jul 2017 17:54:16 -0700 (PDT) From: Fabio Estevam To: boris.brezillon@free-electrons.com Subject: [PATCH v2 1/2] mtd: nand: vf610: Check the return value from clk_prepare_enable() Date: Mon, 17 Jul 2017 21:54:07 -0300 Message-Id: <1500339248-18132-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170717_175438_113235_56843E74 X-CRM114-Status: GOOD ( 10.89 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (festevam[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , linux-mtd@lists.infradead.org, stefan@agner.ch MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Fabio Estevam clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- Changes since v1: - None drivers/mtd/nand/vf610_nfc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 744ab10..9e49672 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -814,12 +814,16 @@ static int vf610_nfc_suspend(struct device *dev) static int vf610_nfc_resume(struct device *dev) { + int err; + struct mtd_info *mtd = dev_get_drvdata(dev); struct vf610_nfc *nfc = mtd_to_nfc(mtd); pinctrl_pm_select_default_state(dev); - clk_prepare_enable(nfc->clk); + err = clk_prepare_enable(nfc->clk); + if (err) + return err; vf610_nfc_preinit_controller(nfc); vf610_nfc_init_controller(nfc);