| Message ID | 1480183585-592-21-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Deferred |
| Headers | show |
On Sun, 27 Nov 2016 03:06:06 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > The denali_dt.c was split out by Altera for the SOCFPGA port. The > Denali IP on SOCFPGA incorporates the hardware ECC fixup feature. > Newer versions are very likely to support it. So, it should be OK > to set DENALI_CAPS_HW_ECC_FIXUP for all DT platforms. Seems like a bad idea. What's the problem with setting this flag in the data->caps definition of each revision? > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/mtd/nand/denali_dt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c > index 293ddb8..9dcd203 100644 > --- a/drivers/mtd/nand/denali_dt.c > +++ b/drivers/mtd/nand/denali_dt.c > @@ -59,6 +59,8 @@ static int denali_dt_probe(struct platform_device *ofdev) > if (data) > denali->caps = data->caps; > > + denali->caps |= DENALI_CAPS_HW_ECC_FIXUP; > + > denali->platform = DT; > denali->dev = &ofdev->dev; > denali->irq = platform_get_irq(ofdev, 0);
Hi Boris, 2016-11-28 1:14 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>: > On Sun, 27 Nov 2016 03:06:06 +0900 > Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > >> The denali_dt.c was split out by Altera for the SOCFPGA port. The >> Denali IP on SOCFPGA incorporates the hardware ECC fixup feature. >> Newer versions are very likely to support it. So, it should be OK >> to set DENALI_CAPS_HW_ECC_FIXUP for all DT platforms. > > Seems like a bad idea. What's the problem with setting this flag in the > data->caps definition of each revision? No problem. I will follow your suggestion in v2.
diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c index 293ddb8..9dcd203 100644 --- a/drivers/mtd/nand/denali_dt.c +++ b/drivers/mtd/nand/denali_dt.c @@ -59,6 +59,8 @@ static int denali_dt_probe(struct platform_device *ofdev) if (data) denali->caps = data->caps; + denali->caps |= DENALI_CAPS_HW_ECC_FIXUP; + denali->platform = DT; denali->dev = &ofdev->dev; denali->irq = platform_get_irq(ofdev, 0);
The denali_dt.c was split out by Altera for the SOCFPGA port. The Denali IP on SOCFPGA incorporates the hardware ECC fixup feature. Newer versions are very likely to support it. So, it should be OK to set DENALI_CAPS_HW_ECC_FIXUP for all DT platforms. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mtd/nand/denali_dt.c | 2 ++ 1 file changed, 2 insertions(+)