| Message ID | 1469830393-13295-5-git-send-email-kdasu.kdev@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Jul 29, 2016 at 06:13:09PM -0400, Kamal Dasu wrote: > In m25p80_read() even though spi_flash_read() is supported > by some drivers, under certain circumstances like unaligned > buffer, address or address range limitations on certain SoCs > let it fallback to core spi reads. Such drivers are expected > to return -EAGAIN so that the m25p80_read() uses standard > spi transfer. You need to send this to the MTD maintainers, I see you've CCed the list but not Brian and any comaintainers he has AFAICT.
Adding Brian for this particular patch since its in the mtd domain. I will specifically add him as well in the next patch set. I do have Vignesh in the list who added the spi_flash_read() in the list. Kamal On Thu, Aug 4, 2016 at 5:07 PM, Mark Brown <broonie@kernel.org> wrote: > On Fri, Jul 29, 2016 at 06:13:09PM -0400, Kamal Dasu wrote: >> In m25p80_read() even though spi_flash_read() is supported >> by some drivers, under certain circumstances like unaligned >> buffer, address or address range limitations on certain SoCs >> let it fallback to core spi reads. Such drivers are expected >> to return -EAGAIN so that the m25p80_read() uses standard >> spi transfer. > > You need to send this to the MTD maintainers, I see you've CCed the list > but not Brian and any comaintainers he has AFAICT.
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 9d68544..3f90542 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -149,8 +149,11 @@ static int m25p80_read(struct spi_nor *nor, loff_t from, size_t len, msg.data_nbits = m25p80_rx_nbits(nor); ret = spi_flash_read(spi, &msg); - *retlen = msg.retlen; - return ret; + /* some drivers might need to fallback to spi transfer */ + if (ret != -EAGAIN) { + *retlen = msg.retlen; + return ret; + } } spi_message_init(&m);
In m25p80_read() even though spi_flash_read() is supported by some drivers, under certain circumstances like unaligned buffer, address or address range limitations on certain SoCs let it fallback to core spi reads. Such drivers are expected to return -EAGAIN so that the m25p80_read() uses standard spi transfer. Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> --- drivers/mtd/devices/m25p80.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)