diff mbox

mtd: brcmnand: defer to devm_ioremap_resource() for error checking

Message ID 1449714797-27492-1-git-send-email-computersforpeace@gmail.com
State Accepted
Commit 207f6582dd9adb8e2ed64b4c64d6d5c009e5bbf9
Headers show

Commit Message

Brian Norris Dec. 10, 2015, 2:33 a.m. UTC
devm_ioremap_resource() does error checking on the 'res' argument, so
drop the error check in bcm6368_nand.c.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Simon Arlott <simon@fire.lp0.eu>
---
Compile tested only

 drivers/mtd/nand/brcmnand/bcm6368_nand.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Arlott Dec. 10, 2015, 9:05 p.m. UTC | #1
On 10/12/15 02:33, Brian Norris wrote:
> devm_ioremap_resource() does error checking on the 'res' argument, so
> drop the error check in bcm6368_nand.c.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Simon Arlott <simon@fire.lp0.eu>

Tested-by: Simon Arlott <simon@fire.lp0.eu>

> ---
> Compile tested only
> 
>  drivers/mtd/nand/brcmnand/bcm6368_nand.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/brcmnand/bcm6368_nand.c b/drivers/mtd/nand/brcmnand/bcm6368_nand.c
> index 7f5359be24f2..34c91b0e1e69 100644
> --- a/drivers/mtd/nand/brcmnand/bcm6368_nand.c
> +++ b/drivers/mtd/nand/brcmnand/bcm6368_nand.c
> @@ -105,9 +105,6 @@ static int bcm6368_nand_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource_byname(pdev,
>  		IORESOURCE_MEM, "nand-int-base");
> -	if (!res)
> -		return -EINVAL;
> -
>  	priv->base = devm_ioremap_resource(dev, res);
>  	if (IS_ERR(priv->base))
>  		return PTR_ERR(priv->base);
>
Brian Norris Dec. 10, 2015, 9:09 p.m. UTC | #2
On Thu, Dec 10, 2015 at 09:05:36PM +0000, Simon Arlott wrote:
> On 10/12/15 02:33, Brian Norris wrote:
> > devm_ioremap_resource() does error checking on the 'res' argument, so
> > drop the error check in bcm6368_nand.c.
> > 
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Cc: Simon Arlott <simon@fire.lp0.eu>
> 
> Tested-by: Simon Arlott <simon@fire.lp0.eu>

Applied to l2-mtd.git
diff mbox

Patch

diff --git a/drivers/mtd/nand/brcmnand/bcm6368_nand.c b/drivers/mtd/nand/brcmnand/bcm6368_nand.c
index 7f5359be24f2..34c91b0e1e69 100644
--- a/drivers/mtd/nand/brcmnand/bcm6368_nand.c
+++ b/drivers/mtd/nand/brcmnand/bcm6368_nand.c
@@ -105,9 +105,6 @@  static int bcm6368_nand_probe(struct platform_device *pdev)
 
 	res = platform_get_resource_byname(pdev,
 		IORESOURCE_MEM, "nand-int-base");
-	if (!res)
-		return -EINVAL;
-
 	priv->base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);