| Message ID | 1439378899-5660-1-git-send-email-festevam@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, Aug 12, 2015 at 08:28:19AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > The "We only connect the NOR to this controller now" phrase > is not really useful for a Kconfig help text, so remove it. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/mtd/spi-nor/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > index 64a4f0e..baa8442 100644 > --- a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -26,6 +26,5 @@ config SPI_FSL_QUADSPI > depends on ARCH_MXC > help > This enables support for the Quad SPI controller in master mode. > - We only connect the NOR to this controller now. I'm inclined to accept this patch, but I'm curious what the intention for the original statement was. Does this mean "this controller could support generic SPI, but this driver only bothers to implement the NOR flash protocol"? > > endif # MTD_SPI_NOR > -- > 1.9.1 > Brian
> -----Original Message----- > From: linux-mtd [mailto:linux-mtd-bounces@lists.infradead.org] On Behalf Of > Brian Norris > Sent: Wednesday, August 12, 2015 10:13 PM > To: Fabio Estevam > Cc: Estevam Fabio-R49496; Huang Shijie; linux-mtd@lists.infradead.org; Xu > Han-B45815 > Subject: Re: [PATCH] spi-nor: Kconfig: Remove unneeded help message > > On Wed, Aug 12, 2015 at 08:28:19AM -0300, Fabio Estevam wrote: > > From: Fabio Estevam <fabio.estevam@freescale.com> > > > > The "We only connect the NOR to this controller now" phrase is not > > really useful for a Kconfig help text, so remove it. > > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > --- > > drivers/mtd/spi-nor/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > index 64a4f0e..baa8442 100644 > > --- a/drivers/mtd/spi-nor/Kconfig > > +++ b/drivers/mtd/spi-nor/Kconfig > > @@ -26,6 +26,5 @@ config SPI_FSL_QUADSPI > > depends on ARCH_MXC > > help > > This enables support for the Quad SPI controller in master mode. > > - We only connect the NOR to this controller now. > > I'm inclined to accept this patch, but I'm curious what the intention for the > original statement was. Does this mean "this controller could support generic > SPI, but this driver only bothers to implement the NOR flash protocol"? This controller doesn't support generic SPI. Just support connect to SPI NOR flash. Best regards Frank Li > > > > > endif # MTD_SPI_NOR > > -- > > 1.9.1 > > > > Brian > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Frank, On Thu, Aug 13, 2015 at 1:49 PM, Li Frank <Frank.Li@freescale.com> wrote: >> I'm inclined to accept this patch, but I'm curious what the intention for the >> original statement was. Does this mean "this controller could support generic >> SPI, but this driver only bothers to implement the NOR flash protocol"? > > This controller doesn't support generic SPI. > Just support connect to SPI NOR flash. Thanks for the clarification. I changed the Kconfig in v2 to make this clear as per your suggestion. Regards, Fabio Estevam
diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig index 64a4f0e..baa8442 100644 --- a/drivers/mtd/spi-nor/Kconfig +++ b/drivers/mtd/spi-nor/Kconfig @@ -26,6 +26,5 @@ config SPI_FSL_QUADSPI depends on ARCH_MXC help This enables support for the Quad SPI controller in master mode. - We only connect the NOR to this controller now. endif # MTD_SPI_NOR