From patchwork Sun Aug 2 10:36:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Barletz X-Patchwork-Id: 502906 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 323F81402BA for ; Sun, 2 Aug 2015 20:39:46 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=OIxNW3C8; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZLqe9-0001qN-QC; Sun, 02 Aug 2015 10:37:37 +0000 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZLqe5-0001nv-1J for linux-mtd@lists.infradead.org; Sun, 02 Aug 2015 10:37:33 +0000 Received: by pacgq8 with SMTP id gq8so2934849pac.3 for ; Sun, 02 Aug 2015 03:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=sLynSh+TVusr6MZF9S/Cswq/olzx82wglcgv/PspVkI=; b=OIxNW3C8ZqjDIwXVUL5jAAv2yoBKO0PByO9JAEEGuY6zf8JnXruvNvMYYWsvyETYJr iJrkCs7MuwKYkUCefDwsBpKWyFT++RV6So/rgnGSg4K41XZb7YCN0rA2aWSKBqu2XAA+ eLLK6JvWoYALjlkc29HJHTcw0xt0d/OTWFUAKTm3vsB2PcR5zPYhr6LnVScUrowrlMTr RLESiA/lEmk8HVu2J33oDpD7dLiHg5b9XM+7nrBze1Qi7yoHHsd3XLYvaq2D2upntWO9 5Q+roh5fpji+EZbAOwIf6nvzzFAVbNmUgn9LT9oHzjW4uvBi374LWCjRTTUcUVmw/aDB NjHA== X-Received: by 10.68.241.230 with SMTP id wl6mr13321831pbc.32.1438511831590; Sun, 02 Aug 2015 03:37:11 -0700 (PDT) Received: from tbarletz-t440.barletz.com (c-73-42-176-67.hsd1.wa.comcast.net. [73.42.176.67]) by smtp.gmail.com with ESMTPSA id qz8sm4396491pbb.91.2015.08.02.03.37.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2015 03:37:10 -0700 (PDT) From: Tomer Barletz To: dwmw2@infradead.org, computersforpeace@gmail.com Subject: [PATCH] Avoid compiler warning by storing the result of rq_data_dir() in an int variable Date: Sun, 2 Aug 2015 03:36:52 -0700 Message-Id: <1438511812-5270-1-git-send-email-barletz@gmail.com> X-Mailer: git-send-email 2.4.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150802_033733_111752_80FB76A4 X-CRM114-Status: UNSURE ( 9.68 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c03:0:0:0:22d listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (barletz[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Tomer Barletz MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org With gcc 5.1 I get: warning: switch condition has boolean value [-Wswitch-bool] Signed-off-by: Tomer Barletz --- drivers/mtd/mtd_blkdevs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 41acc50..8c3715c 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -79,6 +79,7 @@ static int do_blktrans_request(struct mtd_blktrans_ops *tr, { unsigned long block, nsect; char *buf; + int rq; block = blk_rq_pos(req) << 9 >> tr->blkshift; nsect = blk_rq_cur_bytes(req) >> tr->blkshift; @@ -97,7 +98,8 @@ static int do_blktrans_request(struct mtd_blktrans_ops *tr, if (req->cmd_flags & REQ_DISCARD) return tr->discard(dev, block, nsect); - switch(rq_data_dir(req)) { + rq = rq_data_dir(req); + switch(rq) { case READ: for (; nsect > 0; nsect--, block++, buf += tr->blksize) if (tr->readsect(dev, block, buf))