From patchwork Wed Jun 10 20:38:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frans Klaver X-Patchwork-Id: 482865 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3613E140297 for ; Thu, 11 Jun 2015 06:43:00 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=RSjU9NbY; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z2mog-0002Kg-Pg; Wed, 10 Jun 2015 20:41:42 +0000 Received: from mail-wi0-x241.google.com ([2a00:1450:400c:c05::241]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z2mmU-00006S-PS for linux-mtd@lists.infradead.org; Wed, 10 Jun 2015 20:39:28 +0000 Received: by wibbw19 with SMTP id bw19so11967097wib.2 for ; Wed, 10 Jun 2015 13:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IiRVh23150SbCjsKKC5o7bmZVJXayY8wm4x4OzeN4Rs=; b=RSjU9NbYZNz18ys03bRyxHKDPPsC3os4LZ0MEd/3OBeHSaU1H4IOSbAyb/tqCK0h3Z TJeViX8kI+HB2+Q1WQ6n3H5tVNlclLglMSxOLefTLj61IISTeGo0xoynTtmglk0hV/OR zl9R/p2nqhRMgD9nkdRUBmN0DIRFVYys2hBEDZ5tMwkaXfSCk5Kbj7IxxV5ES8LR5KSF XkZt9VTHwrzvqWHFb9s6mlkf/TrdoZmTNCvN0qBleprItL82KttBoswebn0HzS/72QB0 LTUR8V/ZE/111tX3xvNmqsGoPGoiyNBkPOOsAIF7L9oS1pGb6iGpH/xZo7iTSbmn/qzX 53eQ== X-Received: by 10.180.102.74 with SMTP id fm10mr22682080wib.25.1433968744227; Wed, 10 Jun 2015 13:39:04 -0700 (PDT) Received: from localhost.localdomain (82-171-48-45.ip.telfort.nl. [82.171.48.45]) by mx.google.com with ESMTPSA id a8sm9608025wic.22.2015.06.10.13.39.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Jun 2015 13:39:03 -0700 (PDT) From: Frans Klaver To: Brian Norris Subject: [PATCH v2 01/60] mtd: core: tone down suggestion that dev.parent should be set Date: Wed, 10 Jun 2015 22:38:15 +0200 Message-Id: <1433968754-10651-2-git-send-email-fransklaver@gmail.com> X-Mailer: git-send-email 2.4.0 In-Reply-To: <1433968754-10651-1-git-send-email-fransklaver@gmail.com> References: <1433968754-10651-1-git-send-email-fransklaver@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150610_133926_995967_1FAE0BC8 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c05:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (fransklaver[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-mtd@lists.infradead.org, Frans Klaver , David Woodhouse , linux-kernel@vger.kernel.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org add_mtd_device() has a comment suggesting that the caller should have set dev.parent. This is required to have the parent device symlink show up in sysfs, but not for proper operation of the mtd device itself. Currently we have five drivers registering mtd devices during module initialization, so they don't actually provide a parent device to link to. That means we cannot WARN_ON() here, as it would trigger false positives. Make the comment a bit less firm in its assertion that dev.parent should be set. Signed-off-by: Frans Klaver --- drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index d172195..d7967cc 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -423,7 +423,7 @@ int add_mtd_device(struct mtd_info *mtd) } /* Caller should have set dev.parent to match the - * physical device. + * physical device, if appropriate. */ mtd->dev.type = &mtd_devtype; mtd->dev.class = &mtd_class;