| Message ID | 1430553430-21396-4-git-send-email-hofrat@osadl.org |
|---|---|
| State | Rejected |
| Delegated to: | Boris Brezillon |
| Headers | show |
On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > CodingStyle fix only - align function parameters to opening (. > This doesnt look any better to me...
On Mon, 04 May 2015, Vinod Koul wrote: > On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > > CodingStyle fix only - align function parameters to opening (. > > > This doesnt look any better to me... > True it makes little difference when looking at these few lines I guess though the issue is consistency. thx! hofrat
On Mon, 2015-05-04 at 10:51 +0530, Vinod Koul wrote: > On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > > CodingStyle fix only - align function parameters to opening (. > > > This doesnt look any better to me... The goto and return statements were overly indented > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c [] > > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) > > > > /* initiate DMA transfer */ > > if (flctl->chan_fifo0_rx && rlen >= 32 && > > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > > - goto convert; /* DMA success */ > > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > > + goto convert; /* DMA success */ > > > > /* do polling transfer */ > > for (i = 0; i < len_4align; i++) { > > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, > > > > /* initiate DMA transfer */ > > if (flctl->chan_fifo0_tx && rlen >= 32 && > > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > > - return; /* DMA success */ > > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > > + return; /* DMA success */
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c index ffda530..2078c4d 100644 --- a/drivers/mtd/nand/sh_flctl.c +++ b/drivers/mtd/nand/sh_flctl.c @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) /* initiate DMA transfer */ if (flctl->chan_fifo0_rx && rlen >= 32 && - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) - goto convert; /* DMA success */ + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) + goto convert; /* DMA success */ /* do polling transfer */ for (i = 0; i < len_4align; i++) { @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, /* initiate DMA transfer */ if (flctl->chan_fifo0_tx && rlen >= 32 && - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) - return; /* DMA success */ + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) + return; /* DMA success */ /* do polling transfer */ for (i = 0; i < len_4align; i++) {
CodingStyle fix only - align function parameters to opening (. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> --- Patch was compile tested with ap325rxa_defconfig (implies CONFIG_MTD_NAND_SH_FLCTL=y) Patch is against 4.1-rc1 (localversion-next is -next-20150501) drivers/mtd/nand/sh_flctl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)