| Message ID | 1425418844-25177-31-git-send-email-fransklaver@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Mar 03, 2015 at 10:40:14PM +0100, Frans Klaver wrote: > Fix a bug where devices aren't shown in sysfs. > > While at it, make use of the default owner value set by mtdcore. > > Signed-off-by: Frans Klaver <fransklaver@gmail.com> > --- > drivers/mtd/nand/fsl_elbc_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c > index 04b22fd..0cd94a1 100644 > --- a/drivers/mtd/nand/fsl_elbc_nand.c > +++ b/drivers/mtd/nand/fsl_elbc_nand.c > @@ -747,7 +747,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv) > > /* Fill in fsl_elbc_mtd structure */ > priv->mtd.priv = chip; > - priv->mtd.owner = THIS_MODULE; > + priv->mtd.dev.parent = &chip->dev; drivers/mtd/nand/fsl_elbc_nand.c: In function 'fsl_elbc_chip_init': drivers/mtd/nand/fsl_elbc_nand.c:750:30: error: 'struct nand_chip' has no member named 'dev' make[4]: *** [drivers/mtd/nand/fsl_elbc_nand.o] Error 1 > > /* set timeout to maximum */ > priv->fmr = 15 << FMR_CWTO_SHIFT; > -- > 2.2.2 >
On Tue, Mar 10, 2015 at 7:28 AM, Brian Norris <computersforpeace@gmail.com> wrote: > On Tue, Mar 03, 2015 at 10:40:14PM +0100, Frans Klaver wrote: >> Fix a bug where devices aren't shown in sysfs. >> >> While at it, make use of the default owner value set by mtdcore. >> >> Signed-off-by: Frans Klaver <fransklaver@gmail.com> >> --- >> drivers/mtd/nand/fsl_elbc_nand.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c >> index 04b22fd..0cd94a1 100644 >> --- a/drivers/mtd/nand/fsl_elbc_nand.c >> +++ b/drivers/mtd/nand/fsl_elbc_nand.c >> @@ -747,7 +747,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv) >> >> /* Fill in fsl_elbc_mtd structure */ >> priv->mtd.priv = chip; >> - priv->mtd.owner = THIS_MODULE; >> + priv->mtd.dev.parent = &chip->dev; > > drivers/mtd/nand/fsl_elbc_nand.c: In function 'fsl_elbc_chip_init': > drivers/mtd/nand/fsl_elbc_nand.c:750:30: error: 'struct nand_chip' has no member named 'dev' > make[4]: *** [drivers/mtd/nand/fsl_elbc_nand.o] Error 1 Thanks for building this. I thought this might happen even though I spent quite some time trying to prevent it. This should probably have been + priv->mtd.dev.parent = priv->dev; Off to go find out what other configs & targets to build for. Thanks, Frans
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c index 04b22fd..0cd94a1 100644 --- a/drivers/mtd/nand/fsl_elbc_nand.c +++ b/drivers/mtd/nand/fsl_elbc_nand.c @@ -747,7 +747,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv) /* Fill in fsl_elbc_mtd structure */ priv->mtd.priv = chip; - priv->mtd.owner = THIS_MODULE; + priv->mtd.dev.parent = &chip->dev; /* set timeout to maximum */ priv->fmr = 15 << FMR_CWTO_SHIFT;
Fix a bug where devices aren't shown in sysfs. While at it, make use of the default owner value set by mtdcore. Signed-off-by: Frans Klaver <fransklaver@gmail.com> --- drivers/mtd/nand/fsl_elbc_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)