Message ID | 1425117750-22298-7-git-send-email-computersforpeace@gmail.com |
---|---|
State | Accepted |
Commit | e22b7651ef23ad90eed4bdbe75f12194f47d7a4f |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EB3DE140111 for <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2015 21:05:42 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=v3eWRlQQ; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YReG9-0001Cx-H5; Sat, 28 Feb 2015 10:04:33 +0000 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YReEx-0000AL-P1 for linux-mtd@lists.infradead.org; Sat, 28 Feb 2015 10:03:20 +0000 Received: by pdno5 with SMTP id o5so26966586pdn.8 for <linux-mtd@lists.infradead.org>; Sat, 28 Feb 2015 02:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Q/y9Y/XshxiNuygsu4rtyakExzx6Lj+csuLHm5hNuSU=; b=v3eWRlQQFvGEFnWwu4effAUsuXWYlzFBN4/PSOuxo1Sahuz3bNlpgJsBoxOMptJjNx HM7GY5+Ltfh6qZ1JynD1SmuojFXrJuE66mKYsrsi5fwcylNp/AyEQa/yWT9WVaT2BOhj vaXgsJ3eerzmCdre4eSUp+1/dhF5rqWvmj7xRJKRlVHQlkZ0s+09D4vhv+S9gBfwCNjy 1srhMvVtSIYN9k6eYzuehs5cJFwy7Akak258/5mgaqw6+H67Z8KwYPUCg/UcoQ1uEkXN Gj3vkgaQugwkD6qebapOuVitRRSCzVAdddr7+iHPL2f8yW3yP4bj/Te19oLSiy2iSO6N 7Uzw== X-Received: by 10.68.100.99 with SMTP id ex3mr21770867pbb.7.1425117779955; Sat, 28 Feb 2015 02:02:59 -0800 (PST) Received: from localhost.localdomain (cpe-45-48-59-37.socal.res.rr.com. [45.48.59.37]) by mx.google.com with ESMTPSA id j3sm1796204pdb.37.2015.02.28.02.02.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 28 Feb 2015 02:02:59 -0800 (PST) From: Brian Norris <computersforpeace@gmail.com> To: <linux-mtd@lists.infradead.org> Subject: [PATCH 6/7] mtd: blkdevs: remove dead code Date: Sat, 28 Feb 2015 02:02:29 -0800 Message-Id: <1425117750-22298-7-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> References: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150228_020319_852428_666B53FC X-CRM114-Status: UNSURE ( 6.75 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c02:0:0:0:22c listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Cc: Brian Norris <computersforpeace@gmail.com>, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index d08229eb44d8..2b0c52870999 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -171,9 +171,6 @@ static void mtd_blktrans_work(struct work_struct *work) background_done = 0; } - if (req) - __blk_end_request_all(req, -EIO); - spin_unlock_irq(rq->queue_lock); }
The only exit (break) from the preceding loop is nested within a condition which yields req == NULL. This code is dead. Coverity CID #752669 Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- drivers/mtd/mtd_blkdevs.c | 3 --- 1 file changed, 3 deletions(-)