diff mbox

mtd: nand: gpmi: Check for scan_bbt() error

Message ID 1423516953-22938-1-git-send-email-festevam@gmail.com
State Accepted
Commit 899b834a462921a087f92f705d9f85def5892242
Headers show

Commit Message

Fabio Estevam Feb. 9, 2015, 9:22 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

In case of scan_bbt() failure, we should better propagate it.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Huang Shijie Feb. 10, 2015, 3:29 a.m. UTC | #1 
On Mon, Feb 09, 2015 at 07:22:33PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> In case of scan_bbt() failure, we should better propagate it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

thanks

Acked-by: Huang Shijie <shijie.huang@intel.com>
Brian Norris March 31, 2015, 1:28 a.m. UTC | #2 
On Mon, Feb 09, 2015 at 07:22:33PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> In case of scan_bbt() failure, we should better propagate it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Pushed to l2-mtd.git. Thanks!

Brian
diff mbox

Patch

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 33f3c3c..8ce8bb2 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1950,7 +1950,9 @@  static int gpmi_nand_init(struct gpmi_nand_data *this)
 	ret = nand_boot_init(this);
 	if (ret)
 		goto err_out;
-	chip->scan_bbt(mtd);
+	ret = chip->scan_bbt(mtd);
+	if (ret)
+		goto err_out;
 
 	ppdata.of_node = this->pdev->dev.of_node;
 	ret = mtd_device_parse_register(mtd, NULL, &ppdata, NULL, 0);