diff mbox

jffs2: compr_rubin: Remove unused function

Message ID 1420994209-20980-1-git-send-email-rickard_strandqvist@spectrumdigital.se
State Accepted
Commit e4999bbe0802ddff82b3fcbbab3b6274b789aad7
Headers show

Commit Message

Rickard Strandqvist Jan. 11, 2015, 4:36 p.m. UTC
Remove the function pulledbits() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 fs/jffs2/compr_rubin.c |    5 -----
 1 file changed, 5 deletions(-)

Comments

Richard Weinberger Jan. 12, 2015, 3:56 p.m. UTC | #1
On Sun, Jan 11, 2015 at 5:36 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Remove the function pulledbits() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Looks good to me.
Reviewed-by: Richard Weinberger <richard@nod.at>
Brian Norris Jan. 13, 2015, 4:40 a.m. UTC | #2
On Sun, Jan 11, 2015 at 05:36:48PM +0100, Rickard Strandqvist wrote:
> Remove the function pulledbits() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Pushed to l2-mtd.git. Thanks.

Brian
diff mbox

Patch

diff --git a/fs/jffs2/compr_rubin.c b/fs/jffs2/compr_rubin.c
index 92e0644b..556de10 100644
--- a/fs/jffs2/compr_rubin.c
+++ b/fs/jffs2/compr_rubin.c
@@ -84,11 +84,6 @@  static inline int pullbit(struct pushpull *pp)
 	return bit;
 }
 
-static inline int pulledbits(struct pushpull *pp)
-{
-	return pp->ofs;
-}
-
 
 static void init_rubin(struct rubin_state *rs, int div, int *bits)
 {