diff mbox

mtd: denali: fix incorrect bitmask error in denali_setup_dma

Message ID 1420817555-22828-1-git-send-email-dinguyen@opensource.altera.com
State Accepted
Commit 7c272ac5eefb329501aadbd9f21f86232c0f66a9
Headers show

Commit Message

Dinh Nguyen Jan. 9, 2015, 3:32 p.m. UTC 
From: Graham Moore <grmoore@opensource.altera.com>

commit "3157d1ed2309 mtd: denali: remove unnecessary casts" introduced
an error by using a wrong bitmask.

A uint16_t cast was replaced with & 0xff, should be & 0xffff.

Signed-off-by: Graham Moore <grmoore@opensource.altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
 drivers/mtd/nand/denali.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Brian Norris Jan. 13, 2015, 10:33 a.m. UTC | #1 
On Fri, Jan 09, 2015 at 09:32:35AM -0600, dinguyen@opensource.altera.com wrote:
> From: Graham Moore <grmoore@opensource.altera.com>
> 
> commit "3157d1ed2309 mtd: denali: remove unnecessary casts" introduced
> an error by using a wrong bitmask.
> 
> A uint16_t cast was replaced with & 0xff, should be & 0xffff.
> 
> Signed-off-by: Graham Moore <grmoore@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>

Pushed to l2-mtd.git. Thanks!

Brian
diff mbox

Patch

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index b3b7ca1..5e397fb 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1041,7 +1041,7 @@  static void denali_setup_dma(struct denali_nand_info *denali, int op)
 	index_addr(denali, mode | ((addr >> 16) << 8), 0x2200);
 
 	/* 3. set memory low address bits 23:8 */
-	index_addr(denali, mode | ((addr & 0xff) << 8), 0x2300);
+	index_addr(denali, mode | ((addr & 0xffff) << 8), 0x2300);
 
 	/* 4. interrupt when complete, burst len = 64 bytes */
 	index_addr(denali, mode | 0x14000, 0x2400);