| Message ID | 1420030733-10374-2-git-send-email-linux@rempel-privat.de |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, 31 Dec 2014 13:58:52 +0100 Oleksij Rempel <linux@rempel-privat.de> wrote: Please add a commit message. > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> > --- > .../devicetree/bindings/mtd/asm9260-nand.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/asm9260-nand.txt > > diff --git a/Documentation/devicetree/bindings/mtd/asm9260-nand.txt b/Documentation/devicetree/bindings/mtd/asm9260-nand.txt > new file mode 100644 > index 0000000..07bfdac > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/asm9260-nand.txt > @@ -0,0 +1,25 @@ > +* Alphascales's asm9260_nand > + > +Required properties: > +- compatible: "alphascale,asm9260-nand" > +- reg: address range of the nfc block > +- interrupts: irq to be used > +- clocks: clock ids. > +- clock-names: only "sys" and "ahb" should be used. The following are optional properties > +- nand-ecc-strength: see nand.txt > +- nand-ecc-mode: see nand.txt > +- nand-on-flash-bbt: see nand.txt > +- nand-max-chips: maximal number of attached chips. asm9260 support max 2. expect for this one ^ But again, since your NAND controller supports several NAND chips I think the binding should be reworked to represent it. How about making the controller a parent node and then each NAND chip a child of this controller node? Something similar to this binding [1]. Regards, Boris [1]https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mtd/sunxi-nand.txt?id=refs/tags/v3.19-rc2
diff --git a/Documentation/devicetree/bindings/mtd/asm9260-nand.txt b/Documentation/devicetree/bindings/mtd/asm9260-nand.txt new file mode 100644 index 0000000..07bfdac --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/asm9260-nand.txt @@ -0,0 +1,25 @@ +* Alphascales's asm9260_nand + +Required properties: +- compatible: "alphascale,asm9260-nand" +- reg: address range of the nfc block +- interrupts: irq to be used +- clocks: clock ids. +- clock-names: only "sys" and "ahb" should be used. +- nand-ecc-strength: see nand.txt +- nand-ecc-mode: see nand.txt +- nand-on-flash-bbt: see nand.txt +- nand-max-chips: maximal number of attached chips. asm9260 support max 2. + +Example: + + nand@d8000000 { + compatible = "alphascale,asm9260-nand"; + reg = <0x80600000 0x100>; + interrupts = <29>; + nand-ecc-strength = <4>; + nand-ecc-mode = "hw"; + nand-max-chips = <1>; + clocks = <&acc CLKID_SYS_NAND>, <&acc CLKID_AHB_NAND>; + clock-names = "sys", "ahb"; + };
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> --- .../devicetree/bindings/mtd/asm9260-nand.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/asm9260-nand.txt