From patchwork Mon May 26 22:12:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Holler X-Patchwork-Id: 352656 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 02AB714007B for ; Tue, 27 May 2014 08:18:40 +1000 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wp3DD-0005LX-Jz; Mon, 26 May 2014 22:17:43 +0000 Received: from h1446028.stratoserver.net ([85.214.92.142] helo=mail.ahsoftware.de) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wp3Cu-0004bP-Lw for linux-mtd@lists.infradead.org; Mon, 26 May 2014 22:17:25 +0000 Received: by mail.ahsoftware.de (Postfix, from userid 65534) id 7E8FC423C31F; Tue, 27 May 2014 00:17:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.ahsoftware.de X-Spam-Level: X-Spam-Status: No, score=-101.0 required=5.0 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=disabled version=3.3.1 Received: from eiche.ahsoftware (p57B20CCF.dip0.t-ipconnect.de [87.178.12.207]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.ahsoftware.de (Postfix) with ESMTPSA id 8BF38423C327 for ; Tue, 27 May 2014 00:17:02 +0200 (CEST) Received: by eiche.ahsoftware (Postfix, from userid 65534) id CD9E27FC61; Tue, 27 May 2014 00:17:01 +0200 (CEST) Received: from laptopahbt.ahsoftware (unknown [192.168.213.6]) by eiche.ahsoftware (Postfix) with ESMTP id B07DA80C1A; Mon, 26 May 2014 22:13:37 +0000 (UTC) From: Alexander Holler To: linux-kernel@vger.kernel.org Subject: [PATCH 25/27] mtd: nand: ndfc: show device structure in sysfs Date: Tue, 27 May 2014 00:12:50 +0200 Message-Id: <1401142372-14148-26-git-send-email-holler@ahsoftware.de> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1401142372-14148-1-git-send-email-holler@ahsoftware.de> References: <1401142372-14148-1-git-send-email-holler@ahsoftware.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140526_151724_921067_7AB69ECE X-CRM114-Status: GOOD ( 12.65 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.3.2 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, Alexander Holler X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Fix a common error in nand-drivers which do not set up a parent device for the mtd-device by using a new inline function. Signed-off-by: Alexander Holler --- drivers/mtd/nand/ndfc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c index 69eaba6..66366e0 100644 --- a/drivers/mtd/nand/ndfc.c +++ b/drivers/mtd/nand/ndfc.c @@ -170,9 +170,6 @@ static int ndfc_chip_init(struct ndfc_controller *ndfc, chip->ecc.strength = 1; chip->priv = ndfc; - ndfc->mtd.priv = chip; - ndfc->mtd.owner = THIS_MODULE; - flash_np = of_get_next_child(node, NULL); if (!flash_np) return -ENODEV; @@ -248,6 +245,7 @@ static int ndfc_probe(struct platform_device *ofdev) out_be32(ndfc->ndfcbase + offset, be32_to_cpup(reg)); } + mtd_setup_common_members(&ndfc->mtd, &ndfc->chip, ofdev); err = ndfc_chip_init(ndfc, ofdev->dev.of_node); if (err) { iounmap(ndfc->ndfcbase);