| Message ID | 1398248215-26768-2-git-send-email-b32955@freescale.com |
|---|---|
| State | Superseded |
| Headers | show |
On Wednesday, April 23, 2014 at 12:16:49 PM, Huang Shijie wrote: > For the DDR Quad read, the dummy cycles maybe 3 or 6 which is less then 8. > The dummy cycles is actually 8 for SPI fast/dual/quad read. > > This patch makes preparations for the DDR quad read, it fixes the wrong > dummy value for both the spi-nor.c and m25p80.c. > > Signed-off-by: Huang Shijie <b32955@freescale.com> This patch is actually V2, right ? > --- > drivers/mtd/devices/m25p80.c | 5 ++++- > drivers/mtd/spi-nor/spi-nor.c | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > index 1557d8f..693e25f 100644 > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -128,9 +128,12 @@ static int m25p80_read(struct spi_nor *nor, loff_t > from, size_t len, struct spi_device *spi = flash->spi; > struct spi_transfer t[2]; > struct spi_message m; > - int dummy = nor->read_dummy; > + unsigned int dummy = nor->read_dummy; > int ret; > > + /* convert the dummy cycles to the number of byte */ 'bytes', plural ... [...] Best regards, Marek Vasut
On Wed, Apr 23, 2014 at 09:41:26PM +0200, Marek Vasut wrote: > On Wednesday, April 23, 2014 at 12:16:49 PM, Huang Shijie wrote: > > For the DDR Quad read, the dummy cycles maybe 3 or 6 which is less then 8. > > The dummy cycles is actually 8 for SPI fast/dual/quad read. > > > > This patch makes preparations for the DDR quad read, it fixes the wrong > > dummy value for both the spi-nor.c and m25p80.c. > > > > Signed-off-by: Huang Shijie <b32955@freescale.com> > > This patch is actually V2, right ? yes. I mentioned it in the cover letter. Since other patches are the V1. I did not change it to v2. > > > --- > > drivers/mtd/devices/m25p80.c | 5 ++++- > > drivers/mtd/spi-nor/spi-nor.c | 2 +- > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > > index 1557d8f..693e25f 100644 > > --- a/drivers/mtd/devices/m25p80.c > > +++ b/drivers/mtd/devices/m25p80.c > > @@ -128,9 +128,12 @@ static int m25p80_read(struct spi_nor *nor, loff_t > > from, size_t len, struct spi_device *spi = flash->spi; > > struct spi_transfer t[2]; > > struct spi_message m; > > - int dummy = nor->read_dummy; > > + unsigned int dummy = nor->read_dummy; > > int ret; > > > > + /* convert the dummy cycles to the number of byte */ > > 'bytes', plural ... I will change it in the next version. thanks. Huang Shijie
On Thursday, April 24, 2014 at 06:50:29 AM, Huang Shijie wrote: > On Wed, Apr 23, 2014 at 09:41:26PM +0200, Marek Vasut wrote: > > On Wednesday, April 23, 2014 at 12:16:49 PM, Huang Shijie wrote: > > > For the DDR Quad read, the dummy cycles maybe 3 or 6 which is less then > > > 8. The dummy cycles is actually 8 for SPI fast/dual/quad read. > > > > > > This patch makes preparations for the DDR quad read, it fixes the wrong > > > dummy value for both the spi-nor.c and m25p80.c. > > > > > > Signed-off-by: Huang Shijie <b32955@freescale.com> > > > > This patch is actually V2, right ? > > yes. > > I mentioned it in the cover letter. Since other patches are the V1. > I did not change it to v2. So next one is V3 ;-) Best regards, Marek Vasut
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 1557d8f..693e25f 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -128,9 +128,12 @@ static int m25p80_read(struct spi_nor *nor, loff_t from, size_t len, struct spi_device *spi = flash->spi; struct spi_transfer t[2]; struct spi_message m; - int dummy = nor->read_dummy; + unsigned int dummy = nor->read_dummy; int ret; + /* convert the dummy cycles to the number of byte */ + dummy /= 8; + /* Wait till previous write/erase is done. */ ret = nor->wait_till_ready(nor); if (ret) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index f76f3fc..1a12f81 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -77,7 +77,7 @@ static inline int spi_nor_read_dummy_cycles(struct spi_nor *nor) case SPI_NOR_FAST: case SPI_NOR_DUAL: case SPI_NOR_QUAD: - return 1; + return 8; case SPI_NOR_NORMAL: return 0; }
For the DDR Quad read, the dummy cycles maybe 3 or 6 which is less then 8. The dummy cycles is actually 8 for SPI fast/dual/quad read. This patch makes preparations for the DDR quad read, it fixes the wrong dummy value for both the spi-nor.c and m25p80.c. Signed-off-by: Huang Shijie <b32955@freescale.com> --- drivers/mtd/devices/m25p80.c | 5 ++++- drivers/mtd/spi-nor/spi-nor.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-)