| Message ID | 1397023781-1103-1-git-send-email-computersforpeace@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Apr 08, 2014 at 11:09:41PM -0700, Brian Norris wrote: > Fix errors like this: > > ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! > ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > --- > Based on l2-mtd.git:spinor Applied to l2-mtd.git/spinor, to fix the build errors. Brian
On Wednesday, April 09, 2014 at 08:09:41 AM, Brian Norris wrote: > Fix errors like this: > > ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! > ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 Why not EXPORT_SYMBOL_GPL ? Best regards, Marek Vasut
On Wed, Apr 09, 2014 at 10:43:38AM +0200, Marek Vasut wrote: > On Wednesday, April 09, 2014 at 08:09:41 AM, Brian Norris wrote: > > Fix errors like this: > > > > ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! > > ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > Why not EXPORT_SYMBOL_GPL ? _GPL probably makes more sense. Squashed this in and pushed to l2-mtd.git/spinor. Thanks, Brian
On Wednesday, April 09, 2014 at 07:07:20 PM, Brian Norris wrote: > On Wed, Apr 09, 2014 at 10:43:38AM +0200, Marek Vasut wrote: > > On Wednesday, April 09, 2014 at 08:09:41 AM, Brian Norris wrote: > > > Fix errors like this: > > > ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! > > > ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! > > > make[1]: *** [__modpost] Error 1 > > > make: *** [modules] Error 2 > > > > Why not EXPORT_SYMBOL_GPL ? > > _GPL probably makes more sense. Squashed this in and pushed to > l2-mtd.git/spinor. Thanks! btw Brian, completely off-topic, but is there a special ML for SPI NOR stuff or is all of that going through linux-mtd ? Best regards, Marek Vasut
On Wed, Apr 09, 2014 at 07:27:30PM +0200, Marek Vasut wrote: > btw Brian, completely off-topic, but is there a special ML for SPI NOR stuff or > is all of that going through linux-mtd ? All on linux-mtd, AFAIK. Occasionally we'll CC linux-spi as well, since Mark Brown was interested in some of this (mostly to keep "SPI NOR" out of drivers/spi/, I think). Brian
On Wednesday, April 09, 2014 at 07:35:27 PM, Brian Norris wrote: > On Wed, Apr 09, 2014 at 07:27:30PM +0200, Marek Vasut wrote: > > btw Brian, completely off-topic, but is there a special ML for SPI NOR > > stuff or is all of that going through linux-mtd ? > > All on linux-mtd, AFAIK. Occasionally we'll CC linux-spi as well, since > Mark Brown was interested in some of this (mostly to keep "SPI NOR" out > of drivers/spi/, I think). OK, this makes sense. Thanks! Best regards, Marek Vasut
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index f7c9e638623b..2c292f95142e 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -584,6 +584,7 @@ const struct spi_device_id spi_nor_ids[] = { { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, { }, }; +EXPORT_SYMBOL(spi_nor_ids); static const struct spi_device_id *spi_nor_read_id(struct spi_nor *nor) { @@ -1081,6 +1082,7 @@ int spi_nor_scan(struct spi_nor *nor, const struct spi_device_id *id, mtd->eraseregions[i].numblocks); return 0; } +EXPORT_SYMBOL(spi_nor_scan); const struct spi_device_id *spi_nor_match_id(char *name) { @@ -1093,6 +1095,7 @@ const struct spi_device_id *spi_nor_match_id(char *name) } return NULL; } +EXPORT_SYMBOL(spi_nor_match_id); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Huang Shijie <shijie8@gmail.com>");
Fix errors like this: ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- Based on l2-mtd.git:spinor drivers/mtd/spi-nor/spi-nor.c | 3 +++ 1 file changed, 3 insertions(+)