| Message ID | 1396040689-12419-1-git-send-email-alexanders83@web.de |
|---|---|
| State | Rejected |
| Headers | show |
On Friday, March 28, 2014 10:04 PM, Alexander Stein wrote: > > It's no use to debug print a string before checking on NULL. > If the string is NULL, that could be very useful to know when debugging and the print function should handle that gracefully, i.e. by not printing anything for %s. BR // Mats
On Mon, 2014-03-31 at 06:18 +0000, Mats Kärrman wrote: > On Friday, March 28, 2014 10:04 PM, Alexander Stein wrote: > > > > It's no use to debug print a string before checking on NULL. > > > > If the string is NULL, that could be very useful to know when debugging and > the print function should handle that gracefully, i.e. by not printing anything > for %s. %s will just result in (null), I do not see any issue with this.
On Monday 31 March 2014, 12:46:40 wrote Artem Bityutskiy: > On Mon, 2014-03-31 at 06:18 +0000, Mats Kärrman wrote: > > On Friday, March 28, 2014 10:04 PM, Alexander Stein wrote: > > > > > > It's no use to debug print a string before checking on NULL. > > > > > > > If the string is NULL, that could be very useful to know when debugging and > > the print function should handle that gracefully, i.e. by not printing anything > > for %s. > > %s will just result in (null), I do not see any issue with this. Oh, it does? I was not aware of that (kernel-specific) behavior. Sorry for ne noise. Best regards, Alexander
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c index 3aac1ac..e40864f 100644 --- a/drivers/mtd/ubi/kapi.c +++ b/drivers/mtd/ubi/kapi.c @@ -242,11 +242,11 @@ struct ubi_volume_desc *ubi_open_volume_nm(int ubi_num, const char *name, struct ubi_device *ubi; struct ubi_volume_desc *ret; - dbg_gen("open device %d, volume %s, mode %d", ubi_num, name, mode); - if (!name) return ERR_PTR(-EINVAL); + dbg_gen("open device %d, volume %s, mode %d", ubi_num, name, mode); + len = strnlen(name, UBI_VOL_NAME_MAX + 1); if (len > UBI_VOL_NAME_MAX) return ERR_PTR(-EINVAL);
It's no use to debug print a string before checking on NULL. Signed-off-by: Alexander Stein <alexanders83@web.de> --- drivers/mtd/ubi/kapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)